WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
89360
[garden-o-matic] Add support for the GTK builders
https://bugs.webkit.org/show_bug.cgi?id=89360
Summary
[garden-o-matic] Add support for the GTK builders
Zan Dobersek
Reported
2012-06-18 10:17:12 PDT
Most of the work was done in
r120546
[1] to make garden-o-matic usable by other platforms. This bug covers adding support for the GTK port. [1] -
http://trac.webkit.org/changeset/120546
Attachments
Patch
(2.41 KB, patch)
2012-06-18 10:24 PDT
,
Zan Dobersek
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ec2-cq-01
(535.10 KB, application/zip)
2012-06-18 15:03 PDT
,
WebKit Review Bot
no flags
Details
View All
Add attachment
proposed patch, testcase, etc.
Zan Dobersek
Comment 1
2012-06-18 10:24:04 PDT
Created
attachment 148122
[details]
Patch
Adam Barth
Comment 2
2012-06-18 11:40:06 PDT
Comment on
attachment 148122
[details]
Patch Cool! Everything works?
Zan Dobersek
Comment 3
2012-06-18 12:51:34 PDT
(In reply to
comment #2
)
> (From update of
attachment 148122
[details]
) > Cool! Everything works?
Yes, as far as I've tested, except for rebaselining, which is covered by
bug #89299
. Thanks for the review.
WebKit Review Bot
Comment 4
2012-06-18 15:03:13 PDT
Comment on
attachment 148122
[details]
Patch Rejecting
attachment 148122
[details]
from commit-queue. New failing tests: svg/css/getComputedStyle-basic.xhtml Full output:
http://queues.webkit.org/results/12973496
WebKit Review Bot
Comment 5
2012-06-18 15:03:17 PDT
Created
attachment 148180
[details]
Archive of layout-test-results from ec2-cq-01 The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: ec2-cq-01 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
WebKit Review Bot
Comment 6
2012-06-18 15:16:54 PDT
Comment on
attachment 148122
[details]
Patch Clearing flags on attachment: 148122 Committed
r120633
: <
http://trac.webkit.org/changeset/120633
>
WebKit Review Bot
Comment 7
2012-06-18 15:17:00 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug