[GTK] Add a new webkit2 tests slave bot
Created attachment 148072 [details] Patch
Setting the proper component and adding Lucas. BTW Lucas, we would like to use the build from our 64bit release bot (as it already builds wk2) and just run the tests in this new bot. Is this the right approach?
Comment on attachment 148072 [details] Patch You are going to need to add a trigger to the builder you wish to use to supply the build to the test bot. Look at the Apple Lion Debug (Build) bot as an example: { "name": "Apple Lion Debug (Build)", "type": "Build", "builddir": "lion-debug", "platform": "mac-lion", "configuration": "debug", "architectures": ["x86_64"], "triggers": ["lion-debug-tests-wk1", "lion-debug-tests-wk2"], "slavenames": ["apple-xserve-2", "apple-xserve-10"] Next you want to create a Triggerable scheduler with the same name: example: { "type": "Triggerable", "name": "lion-debug-tests-wk1", "builderNames": ["Apple Lion Debug WK1 (Tests)"] Also, you'll need a password generated for your new slave. If you want, I can configure that for you to use the same password as one of your other slaves to make it easy. (they don't have to be unique. Let me know what you'd prefer and I'll do that step for you)
Try something like: { "name": "GTK Linux 64-bit Release", "type": "BuildAndTest", "builddir": "gtk-linux-64-release", "platform": "gtk", "configuration": "release", "architectures": ["x86_64"], "slavenames": ["gtk-linux-slave-2"], "triggers": ['gtk-debug-tests"] }, and { "type": "Triggerable", "name": "gtk-debug-tests", "builderNames": ["GTK Linux 64-bit Release WK2 (Tests)"]
Created attachment 148295 [details] Patch
(In reply to comment #3) > Also, you'll need a password generated for your new slave. If you want, I can configure that for you to use the same password as one of your other slaves to make it easy. (they don't have to be unique. Let me know what you'd prefer and I'll do that step for you) Yes please we need the credentials for the new slave. Regarding reusing an existing password I don't have a strong opinion, for me is almost the same using an existing one or a new password, so I'll let you decide on that.
Comment on attachment 148295 [details] Patch I don't believe you want to create a "GTK Linux 64-bit Release WebKit2 (Tests)", scheduler. That should be removed. (Leave the trigger)
Created attachment 148753 [details] Patch
Looks good. The master should auto-restart when this lands.
Committed r120937: <http://trac.webkit.org/changeset/120937>
Re-opened since this is blocked by 89679
Comment on attachment 148753 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148753&action=review Remove r+, because it was rolled out. > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:143 > + "slavenames": ["gtk-linux-slave-2"], "triggers": ["gtk-linux-64-release-tests-wk2"] The problem is that BuildAndTestFactory's contstructor can't handle triggers, now only BuildFactory can do it. You have 2 options to fix it: - Add triggers to BuildFactory similar to BuildAndTestFactory - Modify gtk-linux-slave-2 from BuildAndTest to Build with trigger the WK1 and WK2 tester
Created attachment 148993 [details] Patch With this new version mastercfg_unittest.py runs smoothly
Comment on attachment 148993 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148993&action=review LGTM, r=me. Please land it when most of the bots are IDLE to avoid problems with master restart. > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:143 > + "triggers": ["gtk-linux-64-release-tests-wk2"], "slavenames": ["gtk-linux-slave-2"] Just a nit: Could you put them into two lines as the other builders does?
Committed r121089: <http://trac.webkit.org/changeset/121089>