Bug 89319 – It should be possible to look at disassembly

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Filip Pizlo]

As a first step, we should import udis86, a two-clause BSD-licensed disassembly library, found here: https://github.com/vmt/udis86.git

[Filip Pizlo]

Created attachment 148034 [details]
the patch

[Sam Weinig]

Comment on attachment 148034 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148034&action=review

> Source/WTF/wtf/Platform.h:888
> +#if !defined(ENABLE_UDIS86) && ENABLE(JIT) && PLATFORM(MAC) && (CPU(X86) || CPU(X86_64))
> +#define ENABLE_UDIS86 1
> +#endif

This should probably be a USE().

[Build Bot]

Comment on attachment 148034 [details]
the patch

Attachment 148034 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12972371

[Early Warning System Bot]

Comment on attachment 148034 [details]
the patch

Attachment 148034 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12977191

[Early Warning System Bot]

Comment on attachment 148034 [details]
the patch

Attachment 148034 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12970552

[Gyuyoung Kim]

Comment on attachment 148034 [details]
the patch

Attachment 148034 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12977190

[Filip Pizlo]

Created attachment 148038 [details]
patch for landing

putting up for ews

[Filip Pizlo]

Created attachment 148039 [details]
take 3

[Gyuyoung Kim]

Comment on attachment 148039 [details]
take 3

Attachment 148039 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12976219

[Gustavo Noronha (kov)]

Comment on attachment 148039 [details]
take 3

Attachment 148039 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12974307

[Geoffrey Garen]

FWIW, llvm has a disassembly sub-module named llvm-mc, which we could use for this.

[WebKit Review Bot]

Comment on attachment 148039 [details]
take 3

Attachment 148039 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12975308

New failing tests:
platform/chromium/compositing/layout-width-change.html
platform/chromium/compositing/render-surface-alpha-blending.html
platform/chromium/compositing/tiny-layer-rotated.html
platform/chromium/compositing/huge-layer-rotated.html
fast/loader/loadInProgress.html
platform/chromium/compositing/3d-corners.html
platform/chromium/compositing/video-frame-size-change.html
platform/chromium/compositing/perpendicular-layer-sorting.html
fast/loader/unload-form-post-about-blank.html
platform/chromium/compositing/child-layer-3d-sorting.html
platform/chromium/compositing/accelerated-drawing/svg-filters.html
platform/chromium/compositing/lost-compositor-context-permanently.html
platform/chromium/compositing/filters/background-filter-blur-outsets.html
platform/chromium/compositing/lost-compositor-context-with-video.html
platform/chromium/compositing/accelerated-drawing/alpha.html
http/tests/xmlhttprequest/zero-length-response.html
http/tests/security/script-crossorigin-loads-correctly.html
platform/chromium/compositing/plugins/webplugin-alpha.html
platform/chromium/compositing/webgl-loses-compositor-context.html
platform/chromium/compositing/backface-visibility-transformed.html
platform/chromium/compositing/lost-compositor-context-with-rendersurface.html
platform/chromium/compositing/lost-compositor-context.html
platform/chromium/compositing/img-layer-grow.html
platform/chromium/compositing/filters/background-filter-blur-off-axis.html
platform/chromium/compositing/filters/background-filter-blur.html
platform/chromium/compositing/lost-compositor-context-twice.html

[WebKit Review Bot]

Created attachment 148047 [details]
Archive of layout-test-results from ec2-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Filip Pizlo]

Created attachment 148206 [details]
take 4

[Filip Pizlo]

Created attachment 148214 [details]
take 5

[Filip Pizlo]

Landed in http://trac.webkit.org/changeset/120745