Bug 89319 - It should be possible to look at disassembly
Summary: It should be possible to look at disassembly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-17 18:56 PDT by Filip Pizlo
Modified: 2012-06-19 12:45 PDT (History)
7 users (show)

See Also:

Attachments
the patch (360.84 KB, patch)
2012-06-17 19:04 PDT, Filip Pizlo 		sam: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
patch for landing (365.81 KB, patch)
2012-06-17 19:43 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
take 3 (366.16 KB, patch)
2012-06-17 20:00 PDT, Filip Pizlo 		gyuyoung.kim: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-01 (951.12 KB, application/zip)
2012-06-17 21:33 PDT, WebKit Review Bot 		no flags Details
take 4 (367.30 KB, patch)
2012-06-18 17:15 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
take 5 (368.72 KB, patch)
2012-06-18 17:45 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-06-17 18:56:22 PDT 
As a first step, we should import udis86, a two-clause BSD-licensed disassembly library, found here: https://github.com/vmt/udis86.git
Comment 1 Filip Pizlo 2012-06-17 19:04:17 PDT 
Created attachment 148034 [details]
the patch
Comment 2 Sam Weinig 2012-06-17 19:13:48 PDT 
Comment on attachment 148034 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148034&action=review

> Source/WTF/wtf/Platform.h:888
> +#if !defined(ENABLE_UDIS86) && ENABLE(JIT) && PLATFORM(MAC) && (CPU(X86) || CPU(X86_64))
> +#define ENABLE_UDIS86 1
> +#endif

This should probably be a USE().
Comment 3 Build Bot 2012-06-17 19:26:47 PDT 
Comment on attachment 148034 [details]
the patch

Attachment 148034 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12972371
Comment 4 Early Warning System Bot 2012-06-17 19:32:52 PDT 
Comment on attachment 148034 [details]
the patch

Attachment 148034 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12977191
Comment 5 Early Warning System Bot 2012-06-17 19:33:06 PDT 
Comment on attachment 148034 [details]
the patch

Attachment 148034 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12970552
Comment 6 Gyuyoung Kim 2012-06-17 19:39:44 PDT 
Comment on attachment 148034 [details]
the patch

Attachment 148034 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12977190
Comment 7 Filip Pizlo 2012-06-17 19:43:41 PDT 
Created attachment 148038 [details]
patch for landing

putting up for ews
Comment 8 Filip Pizlo 2012-06-17 20:00:28 PDT 
Created attachment 148039 [details]
take 3
Comment 9 Gyuyoung Kim 2012-06-17 20:57:22 PDT 
Comment on attachment 148039 [details]
take 3

Attachment 148039 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12976219
Comment 10 Gustavo Noronha (kov) 2012-06-17 21:07:21 PDT 
Comment on attachment 148039 [details]
take 3

Attachment 148039 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12974307
Comment 11 Geoffrey Garen 2012-06-17 21:28:11 PDT 
FWIW, llvm has a disassembly sub-module named llvm-mc, which we could use for this.
Comment 12 WebKit Review Bot 2012-06-17 21:33:53 PDT 
Comment on attachment 148039 [details]
take 3

Attachment 148039 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12975308

New failing tests:
platform/chromium/compositing/layout-width-change.html
platform/chromium/compositing/render-surface-alpha-blending.html
platform/chromium/compositing/tiny-layer-rotated.html
platform/chromium/compositing/huge-layer-rotated.html
fast/loader/loadInProgress.html
platform/chromium/compositing/3d-corners.html
platform/chromium/compositing/video-frame-size-change.html
platform/chromium/compositing/perpendicular-layer-sorting.html
fast/loader/unload-form-post-about-blank.html
platform/chromium/compositing/child-layer-3d-sorting.html
platform/chromium/compositing/accelerated-drawing/svg-filters.html
platform/chromium/compositing/lost-compositor-context-permanently.html
platform/chromium/compositing/filters/background-filter-blur-outsets.html
platform/chromium/compositing/lost-compositor-context-with-video.html
platform/chromium/compositing/accelerated-drawing/alpha.html
http/tests/xmlhttprequest/zero-length-response.html
http/tests/security/script-crossorigin-loads-correctly.html
platform/chromium/compositing/plugins/webplugin-alpha.html
platform/chromium/compositing/webgl-loses-compositor-context.html
platform/chromium/compositing/backface-visibility-transformed.html
platform/chromium/compositing/lost-compositor-context-with-rendersurface.html
platform/chromium/compositing/lost-compositor-context.html
platform/chromium/compositing/img-layer-grow.html
platform/chromium/compositing/filters/background-filter-blur-off-axis.html
platform/chromium/compositing/filters/background-filter-blur.html
platform/chromium/compositing/lost-compositor-context-twice.html
Comment 13 WebKit Review Bot 2012-06-17 21:33:59 PDT 
Created attachment 148047 [details]
Archive of layout-test-results from ec2-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 14 Filip Pizlo 2012-06-18 17:15:20 PDT 
Created attachment 148206 [details]
take 4
Comment 15 Filip Pizlo 2012-06-18 17:45:31 PDT 
Created attachment 148214 [details]
take 5
Comment 16 Filip Pizlo 2012-06-19 12:45:50 PDT 
Landed in http://trac.webkit.org/changeset/120745