RESOLVED FIXED 89318
REGRESSION (r120548): hidpi tests are asserting after r120548 
https://bugs.webkit.org/show_bug.cgi?id=89318
Summary REGRESSION (r120548): hidpi tests are asserting after r120548
Simon Fraser (smfr)
Reported 2012-06-17 17:28:12 PDT
Lots of crashes on the WK2 bot after r120548 http://trac.webkit.org/changeset/120548 02:01:59.920 91387 ASSERTION FAILED: bitmap->size() == updateSize 02:01:59.920 91387 /Volumes/Data/slave/lion-debug/build/Source/WebKit2/UIProcess/BackingStore.cpp(64) : void WebKit::BackingStore::incorporateUpdate(const WebKit::UpdateInfo &) 02:01:59.920 91387 1 0x10384bb37 WebKit::BackingStore::incorporateUpdate(WebKit::UpdateInfo const&) 02:01:59.920 91387 2 0x103885650 WebKit::DrawingAreaProxyImpl::incorporateUpdate(WebKit::UpdateInfo const&) 02:01:59.920 91387 3 0x103885504 WebKit::DrawingAreaProxyImpl::update(unsigned long long, WebKit::UpdateInfo const&) 02:01:59.920 91387 4 0x103887d18 void CoreIPC::callMemberFunction<WebKit::DrawingAreaProxy, void (WebKit::DrawingAreaProxy::*)(unsigned long long, WebKit::UpdateInfo const&), unsigned long long, WebKit::UpdateInfo>(CoreIPC::Arguments2<unsigned long long, WebKit::UpdateInfo> const&, WebKit::DrawingAreaProxy*, void (WebKit::DrawingAreaProxy::*)(unsigned long long, WebKit::UpdateInfo const&)) 02:01:59.921 91387 5 0x1038875a1 void CoreIPC::handleMessage<Messages::DrawingAreaProxy::Update, WebKit::DrawingAreaProxy, void (WebKit::DrawingAreaProxy::*)(unsigned long long, WebKit::UpdateInfo const&)>(CoreIPC::ArgumentDecoder*, WebKit::DrawingAreaProxy*, void (WebKit::DrawingAreaProxy::*)(unsigned long long, WebKit::UpdateInfo const&)) 02:01:59.921 91387 6 0x103887340 WebKit::DrawingAreaProxy::didReceiveDrawingAreaProxyMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::ArgumentDecoder*) 02:01:59.921 91387 7 0x103a7f8a3 WebKit::WebPageProxy::didReceiveMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::ArgumentDecoder*) 02:01:59.921 91387 8 0x103b14226 WebKit::WebProcessProxy::didReceiveMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::ArgumentDecoder*) 02:01:59.921 91387 9 0x1039a9227 WebKit::WebConnectionToWebProcess::didReceiveMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::ArgumentDecoder*) 02:01:59.921 91387 10 0x1039a926d non-virtual thunk to WebKit::WebConnectionToWebProcess::didReceiveMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::ArgumentDecoder*) 02:01:59.921 91387 11 0x10385ee9c CoreIPC::Connection::dispatchMessage(CoreIPC::Connection::Message<CoreIPC::ArgumentDecoder>&) 02:01:59.921 91387 12 0x103861589 CoreIPC::Connection::dispatchOneMessage() 02:01:59.921 91387 13 0x103868090 WTF::FunctionWrapper<void (CoreIPC::Connection::*)()>::operator()(CoreIPC::Connection*) 02:01:59.921 91387 14 0x103868015 WTF::BoundFunctionImpl<WTF::FunctionWrapper<void (CoreIPC::Connection::*)()>, void ()(CoreIPC::Connection*)>::operator()() 02:01:59.921 91387 15 0x106e4ab15 WTF::Function<void ()()>::operator()() const 02:01:59.922 91387 16 0x106e4a8a7 WebCore::RunLoop::performWork() 02:01:59.922 91387 17 0x106e4bb9e WebCore::RunLoop::performWork(void*) 02:01:59.922 91387 18 0x7fff821c86e1 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ 02:01:59.922 91387 19 0x7fff821c7f4d __CFRunLoopDoSources0 02:01:59.922 91387 20 0x7fff821eed39 __CFRunLoopRun 02:01:59.922 91387 21 0x7fff821ee676 CFRunLoopRunSpecific 02:01:59.922 91387 22 0x7fff87835f9f -[NSRunLoop(NSRunLoop) runMode:beforeDate:] 02:01:59.922 91387 23 0x10380481c WTR::TestController::platformRunUntil(bool&, double) 02:01:59.922 91387 24 0x1038000f5 WTR::TestController::runUntil(bool&, WTR::TestController::TimeoutDuration) 02:01:59.922 91387 25 0x1038056d4 WTR::TestInvocation::invoke() 02:01:59.923 91387 26 0x10380079e WTR::TestController::runTest(char const*) 02:01:59.923 91387 27 0x1038008a2 WTR::TestController::runTestingServerLoop() 02:01:59.923 91387 28 0x1037feec0 WTR::TestController::run() 02:01:59.923 91387 29 0x1037fdbd2 WTR::TestController::TestController(int, char const**) 02:01:59.923 91387 30 0x1037fd963 WTR::TestController::TestController(int, char const**) 02:01:59.923 91387 31 0x1037fb47f main
Attachments
Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 2 2012-06-17 21:34:27 PDT
Darn. I tested in release but not in debug... We might want to revert http://trac.webkit.org/changeset/120548 and http://trac.webkit.org/changeset/120547 so I can sort this out offline. If need be, we can revert http://trac.webkit.org/changeset/120541 as well.
Adam Barth
Comment 3 2012-06-18 14:10:00 PDT
Sorry for the delay. Looking now.
Adam Barth
Comment 4 2012-06-18 14:30:41 PDT
internals.setDeviceScaleFactor doesn't work for WebKit2 because WebKit2 keeps a cache of the device scale factor in the WebKit layer. I'm going to roll out the entire patch sequence.
Adam Barth
Comment 5 2012-06-18 14:31:31 PDT
Rollout is in https://bugs.webkit.org/show_bug.cgi?id=89383
Adam Barth
Comment 6 2012-06-18 14:40:55 PDT
Should be fixed in http://trac.webkit.org/changeset/120627
Note You need to log in before you can comment on or make changes to this bug.