garden-o-matic 'Results' panel is broken for the Apple platform

[Simon Fraser (smfr)]

The 'Results' tab is dimmed out (but selectable!), and blank if platform=apple.

[Simon Fraser (smfr)]

Er, the Results panel is blank for Chromium too. What's it supposed to do?

[Adam Barth]

When you click the "Examine" button next to a failure, it populates the results tab.

[Simon Fraser (smfr)]

OIC, the Results tab gets populated when you look at individual tests. Weird UI.

[Adam Barth]

> Weird UI.

Suggestions welcome.  :)

[Simon Fraser (smfr)]

Created attachment 148022 [details]
Patch

[Adam Barth]

Comment on attachment 148022 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148022&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:614
> +        $.each(suffixList, function(index, suffix) {
> +            var url = stem + testNameStem + suffix;
> +            net.probe(url, {
> +                success: function() {
> +                    resultURLs.push(url);
> +                    tracker.requestComplete();
> +                },
> +                error: function() {
> +                    tracker.requestComplete();
> +                },
> +            });

This part looks duplicated.  I wonder if we can pull this out of both sides of the if statement and share it.

[Simon Fraser (smfr)]

http://trac.webkit.org/changeset/120555