RESOLVED FIXED 89310
garden-o-matic 'Results' panel is broken for the Apple platform 
https://bugs.webkit.org/show_bug.cgi?id=89310
Summary garden-o-matic 'Results' panel is broken for the Apple platform
Simon Fraser (smfr)
Reported 2012-06-17 09:28:41 PDT
The 'Results' tab is dimmed out (but selectable!), and blank if platform=apple.
Attachments
Patch (16.81 KB, patch)
2012-06-17 12:53 PDT, Simon Fraser (smfr) 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2012-06-17 10:13:01 PDT
Er, the Results panel is blank for Chromium too. What's it supposed to do?
Adam Barth
Comment 2 2012-06-17 10:13:42 PDT
When you click the "Examine" button next to a failure, it populates the results tab.
Simon Fraser (smfr)
Comment 3 2012-06-17 10:16:15 PDT
OIC, the Results tab gets populated when you look at individual tests. Weird UI.
Adam Barth
Comment 4 2012-06-17 10:19:18 PDT
> Weird UI. Suggestions welcome. :)
Simon Fraser (smfr)
Comment 5 2012-06-17 12:53:01 PDT
Created attachment 148022 [details] Patch
Adam Barth
Comment 6 2012-06-17 13:40:38 PDT
Comment on attachment 148022 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148022&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:614 > + $.each(suffixList, function(index, suffix) { > + var url = stem + testNameStem + suffix; > + net.probe(url, { > + success: function() { > + resultURLs.push(url); > + tracker.requestComplete(); > + }, > + error: function() { > + tracker.requestComplete(); > + }, > + }); This part looks duplicated. I wonder if we can pull this out of both sides of the if statement and share it.
Simon Fraser (smfr)
Comment 7 2012-06-17 17:20:27 PDT
http://trac.webkit.org/changeset/120555
Note You need to log in before you can comment on or make changes to this bug.