Bug 89298 - [chromium] Plumb accelerated animation setting to GraphicsLayerChromium
Summary: [chromium] Plumb accelerated animation setting to GraphicsLayerChromium
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: vollick
URL:
Keywords:
Depends on: 89303
Blocks: 89311
  Show dependency treegraph
 
Reported: 2012-06-16 20:33 PDT by vollick
Modified: 2013-04-15 07:52 PDT (History)
10 users (show)

See Also:


Attachments
Patch (84.15 KB, patch)
2012-06-16 20:44 PDT, vollick
no flags Details | Formatted Diff | Diff
Patch (19.48 KB, patch)
2012-06-17 10:28 PDT, vollick
no flags Details | Formatted Diff | Diff
Patch (30.19 KB, patch)
2012-07-03 13:35 PDT, vollick
jamesr: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description vollick 2012-06-16 20:33:07 PDT
Certain CCSettings were made global to allow them to be accessed by a LayerChromium that had not yet been added to the tree. This is unfortunate, and it also turns out to be unnecessary. The setting can be plumbed to GraphicsLayerChromium, who can do the check. This depends on a chromium patch to prepare for the change.
Comment 1 vollick 2012-06-16 20:44:05 PDT
Created attachment 148006 [details]
Patch

I'm very sorry for the churn, but I think that this approach will end up being much simpler and safer than the old one.

This patch is essentially a revert of 88384, but please note the changes to RenderLayerCompositor and RenderLayerBacking for the new plumbing.
Comment 2 WebKit Review Bot 2012-06-16 20:47:44 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 WebKit Review Bot 2012-06-16 21:07:48 PDT
Comment on attachment 148006 [details]
Patch

Attachment 148006 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12967803
Comment 4 vollick 2012-06-17 06:38:24 PDT
Comment on attachment 148006 [details]
Patch

There is too much happening in this bug. I will split it up.
Comment 5 vollick 2012-06-17 10:28:26 PDT
Created attachment 148015 [details]
Patch
Comment 6 vollick 2012-07-03 13:35:19 PDT
Created attachment 150664 [details]
Patch
Comment 7 James Robinson 2012-07-30 20:41:25 PDT
Comment on attachment 150664 [details]
Patch

I don't think modifying the cross-platform GraphicsLayer API for this chromium-specific concern makes sense.