RESOLVED FIXED 89282
[EFL] Rebaseline MathML tests after r120492 
https://bugs.webkit.org/show_bug.cgi?id=89282
Summary [EFL] Rebaseline MathML tests after r120492
Chris Dumez
Reported 2012-06-16 04:58:45 PDT
Several MathML tests need rebaselining after r120492 (Bug 88476).
Attachments
Patch (261.67 KB, patch)
2012-06-16 05:03 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-06-16 05:03:25 PDT
Created attachment 147963 [details] Patch Could someone please cq+ ?
Dave Barton
Comment 2 2012-06-16 12:12:08 PDT
Thanks! Do you want me to let someone know when I've changed some MathML pixel test results? Or is there an easy way for me to rebaseline the MathML tests myself for EFL? For instance, the patch for bug 43819 will change basically all the MathML pixel test results. (That should be the last such massive change for a while.) In particular, it will enable the STIXGeneral font during layout tests, which may help make pixel results similar or identical across ports. Note also that after that patch lands, I believe all 4 mathml occurrences in LayoutTests/platform/efl/Skipped can be removed (not sure about the integral sign one), and MathML layout in general should be better, though not yet perfect. If you see any problems then with these 4 or other MathML tests on EFL, please let me know, thanks!
Chris Dumez
Comment 3 2012-06-16 12:18:06 PDT
(In reply to comment #2) > Thanks! Do you want me to let someone know when I've changed some MathML pixel test results? Or is there an easy way for me to rebaseline the MathML tests myself for EFL? > > For instance, the patch for bug 43819 will change basically all the MathML pixel test results. (That should be the last such massive change for a while.) In particular, it will enable the STIXGeneral font during layout tests, which may help make pixel results similar or identical across ports. > > Note also that after that patch lands, I believe all 4 mathml occurrences in LayoutTests/platform/efl/Skipped can be removed (not sure about the integral sign one), and MathML layout in general should be better, though not yet perfect. If you see any problems then with these 4 or other MathML tests on EFL, please let me know, thanks! Thanks for notifying me. I'll watch Bug 43819 and do the necessary rebaselining when it lands. I'll also make sure to test the Skipped MathML tests then.
WebKit Review Bot
Comment 4 2012-06-16 15:59:47 PDT
Comment on attachment 147963 [details] Patch Clearing flags on attachment: 147963 Committed r120535: <http://trac.webkit.org/changeset/120535>
WebKit Review Bot
Comment 5 2012-06-16 16:00:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.