Bug 89280 – REGRESSION (r120246): <video> progress control doesn't draw handle on Mac

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Tim Horton]

See attached screenshots. The little grabby handle on <video> on Mac broke in http://trac.webkit.org/changeset/120246. Possible that we should have investigated instead of rebaselining the tests, unfortunate that we don't have pixel tests in a good state.

[Tim Horton]

Created attachment 147959 [details]
before

[Tim Horton]

Created attachment 147960 [details]
after

[Radar WebKit Bug Importer]

<rdar://problem/11683093>

[Silvia Pfeiffer]

Can you check if the volume thumb is still there?

It may be related to the change of media slider thumbs to a shadowPseudoId of "webkit-media-slider-thumb" from "webkit-slider-thumb".

[Tim Horton]

(In reply to comment #4)
> Can you check if the volume thumb is still there?

The volume thumb is also missing.

> It may be related to the change of media slider thumbs to a shadowPseudoId of "webkit-media-slider-thumb" from "webkit-slider-thumb".

[Silvia Pfeiffer]

OK, since my build doesn't replicate the bug, could you check whether changing this rule in WebCor/css/html.cc to add  "input[type="range"]::-webkit-media-slider-thumb" might fix it?

input[type="range"]::-webkit-slider-thumb {
    -webkit-appearance: sliderthumb-horizontal;
    -webkit-box-sizing: border-box;
    display: block;
    position: relative;
}

[Silvia Pfeiffer]

If that works, also add input[type="range"]::-webkit-media-slider-container to the rule of input[type="range"]::-webkit-slider-container .

[Tim Horton]

(In reply to comment #7)
> If that works, also add input[type="range"]::-webkit-media-slider-container to the rule of input[type="range"]::-webkit-slider-container .

Works great, will you land it? I'm not 100% sure what I'm changing, so it's hard to write a changelog, nor am I sure that was the final goal versus just a test.

[Silvia Pfeiffer]

(In reply to comment #8)
> (In reply to comment #7)
> > If that works, also add input[type="range"]::-webkit-media-slider-container to the rule of input[type="range"]::-webkit-slider-container .
> 
> Works great, will you land it? I'm not 100% sure what I'm changing, so it's hard to write a changelog, nor am I sure that was the final goal versus just a test.

Can do. Give me an hour or so.

[Silvia Pfeiffer]

Created attachment 147991 [details]
patch for review

[WebKit Review Bot]

Comment on attachment 147991 [details]
patch for review

Clearing flags on attachment: 147991

Committed r120596: <http://trac.webkit.org/changeset/120596>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Simon Fraser (smfr)]

Looks like this cause media/controls-after-reload.html to fail:
http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r120608%20(242)/media/controls-after-reload-pretty-diff.html

[Tim Horton]

(In reply to comment #13)
> Looks like this cause media/controls-after-reload.html to fail:
> http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r120608%20(242)/media/controls-after-reload-pretty-diff.html

Probably the rebaseline in http://trac.webkit.org/changeset/120345 was wrong.

[Silvia Pfeiffer]

If the controls look ok, yes, I would assume the rebaseline should be redone.