layoutTestController.setBackingScaleFactor is redundant with (and less awesome than) internals.settings.setDeviceScaleFactor
Created attachment 147949 [details] Patch
Comment on attachment 147949 [details] Patch I ran these tests on apple-mac on Lion in WebKit2 and they seem to still work (even when running --pixel-tests).
Comment on attachment 147949 [details] Patch Yay simplicity!
Comment on attachment 147949 [details] Patch Attachment 147949 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12960902 New failing tests: svg/custom/focus-ring.svg svg/custom/createImageElement.svg svg/custom/group-opacity.svg svg/custom/image-parent-translation.xhtml
Created attachment 147974 [details] Archive of layout-test-results from ec2-cr-linux-04 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-04 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment on attachment 147949 [details] Patch Clearing flags on attachment: 147949 Committed r120541: <http://trac.webkit.org/changeset/120541>
All reviewed patches have been landed. Closing bug.
The following tests started to fail on EFL after this patch: fast/canvas/2d.backingStorePixelRatio.html fast/canvas/2d.imageDataHD.html The diffs look like: --- /home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/layout-test-results/fast/canvas/2d.backingStorePixelRatio-expected.txt +++ /home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/layout-test-results/fast/canvas/2d.backingStorePixelRatio-actual.txt @@ -1,3 +1,3 @@ -context1.webkitBackingStorePixelRatio is 1 -context2.webkitBackingStorePixelRatio is 1 +CONSOLE MESSAGE: line 22: TypeError: 'undefined' is not a function (evaluating 'layoutTestController.setBackingScaleFactor') +FAIL: Timed out waiting for notifyDone to be called --- /home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/layout-test-results/fast/canvas/2d.imageDataHD-expected.txt +++ /home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/layout-test-results/fast/canvas/2d.imageDataHD-actual.txt @@ -1,2 +1,3 @@ -High-DPI canvas is not enabled. +CONSOLE MESSAGE: line 117: TypeError: 'undefined' is not a function (evaluating 'layoutTestController.setBackingScaleFactor') +FAIL: Timed out waiting for notifyDone to be called
Hopefully these will be fixed by http://trac.webkit.org/changeset/120547
(In reply to comment #9) > Hopefully these will be fixed by http://trac.webkit.org/changeset/120547 Yes, all good now. Thanks.
Re-opened since this is blocked by 89383
Created attachment 148496 [details] Patch
Comment on attachment 148496 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148496&action=review > Source/WebCore/ChangeLog:8 > + Using this itnernals API causes the apple-mac port to ASSERT in WebKit2 itnernals -> internals. perhaps "window.internals" to be clearer about what internals this means? > Source/WebCore/ChangeLog:13 > + Tests should use setBackScalingFactor instead. BackScaling -> BackingScale > LayoutTests/fast/hidpi/device-scale-factor-paint.html:12 > + setTimeout(function() { layoutTestController.notifyDone(); }, 0); how about: setTimeout(layoutTestController.notifyDone); ? why do we need a timeout at all?
> why do we need a timeout at all? Dunno. I'm just following the idiom used by the rest of the hidpi tests. I assume it's because the callback from the injected bundle has a strange callstack and we want a clean call stack when we re-enter the LayoutTestController.
Created attachment 148497 [details] Patch
Comment on attachment 148497 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148497&action=review > LayoutTests/fast/hidpi/device-scale-factor-paint.html:12 > + setTimeout(function() { layoutTestController.notifyDone(); }, 0); setTimeout(layoutTestController.notifyDone); would be simpler
Committed r120883: <http://trac.webkit.org/changeset/120883>