Before this patch, if a replica layer has a descendant replica child, the child layer does not render the result in the parent layer's surface because TextureMapperPaintOptions does not keep current surface.
Created attachment 147942 [details] patch v.1
I need some advice. I'm afraid about 2 points after amending a Layout test in order to cover this bug. 1. This amendment effects all ports's test result, especially png files. I need how I handle it. 2. This layout test is in Qt's Skipped files for some reason, so this amendment actually does not cover Qt's Texmap now. Is it ok? I am looking forward to your kind response.
Comment on attachment 147942 [details] patch v.1 Attachment 147942 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12969341 New failing tests: compositing/reflections/animation-inside-reflection.html
Created attachment 147989 [details] Archive of layout-test-results from ec2-cr-linux-04 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-04 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment on attachment 147942 [details] patch v.1 View in context: https://bugs.webkit.org/attachment.cgi?id=147942&action=review > LayoutTests/ChangeLog:8 > + Before this patch, if a replica layer has a descendant replica child, the child > + layer does not render the result in the parent layer's surface because > + TextureMapperPaintOptions does not keep current surface. Please describe in the changelog the change to the test. > Source/WebCore/ChangeLog:8 > + Before this patch, if a replica layer has a descendant replica child, the child > + layer does not render the result in the parent layer's surface because > + TextureMapperPaintOptions does not keep current surface. Please describe what the patch actually adds/fixes.
Created attachment 148001 [details] patch v.2
Created attachment 148002 [details] patch v.3
I made mistake to push patch v.2. The test result of patch v.2. is without this patch, so you can see how test (compositing/reflections/animation-inside-reflection.html) result is different between patch v.2 and patch v.3
Comment on attachment 148002 [details] patch v.3 Attachment 148002 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12964889 New failing tests: compositing/reflections/animation-inside-reflection.html
Created attachment 148005 [details] Archive of layout-test-results from ec2-cr-linux-01 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-01 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
(In reply to comment #9) > (From update of attachment 148002 [details]) > Attachment 148002 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/12964889 > > New failing tests: > compositing/reflections/animation-inside-reflection.html I expected this failure. I wonder if I want to progress, I MUST make new test results for all ports? I'm some confused. Help me. :)
Committed r120588: <http://trac.webkit.org/changeset/120588>
(In reply to comment #12) > Committed r120588: <http://trac.webkit.org/changeset/120588> Oops. Sorry, I messed up with webkit-patch and indicated this bug number instead of the righ tone 8226. Now reopening...
(In reply to comment #13) > (In reply to comment #12) > > Committed r120588: <http://trac.webkit.org/changeset/120588> > > Oops. Sorry, I messed up with webkit-patch and indicated this bug number instead of the righ tone 8226. I meant "...of the right one: bug 89226". Sorry again. It's Monday, forgive me :)
(In reply to comment #11) > (In reply to comment #9) > > (From update of attachment 148002 [details] [details]) > > Attachment 148002 [details] [details] did not pass chromium-ews (chromium-xvfb): > > Output: http://queues.webkit.org/results/12964889 > > > > New failing tests: > > compositing/reflections/animation-inside-reflection.html > > I expected this failure. > I wonder if I want to progress, I MUST make new test results for all ports? > I'm some confused. Help me. :) You should update TestExpectations to reflect the result. Ask for help on #webkit if you're doing this for the first time :)
Comment on attachment 148002 [details] patch v.3 View in context: https://bugs.webkit.org/attachment.cgi?id=148002&action=review Patch is good. Need to update results for chromium (and other ports if needed) when submitting. > LayoutTests/ChangeLog:10 > + Describe that you added a test that reproduces the issue.
Created attachment 148999 [details] patch v.4 I found the solution in http://trac.webkit.org/wiki/CreatingLayoutTests
Attachment 148999 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/comp..." exit_code: 1 LayoutTests/platform/mac/compositing/reflections/animation-inside-reflection-expected.png:0: Image lacks a checksum. Generate pngs using run-webkit-tests to ensure they have a checksum. [image/png] [5] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 149158 [details] patch v.5
Comment on attachment 149158 [details] patch v.5 Clearing flags on attachment: 149158 Committed r121179: <http://trac.webkit.org/changeset/121179>
All reviewed patches have been landed. Closing bug.