Bug 89264 – Plumb Scrollbar button dimensions down to WebThemeEngine

• Status: REOPENED
• Component: New Bugs

[Scott Graham]

[Chromium] Plumb Scrollbar button dimensions down to native_theme

[Scott Graham]

Created attachment 148149 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Scott Graham]

Created attachment 148151 [details]
Patch

[Scott Graham]

(Requires https://chromiumcodereview.appspot.com/10532207/ to land on Chromium side first.)

[James Robinson]

Comment on attachment 148149 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148149&action=review

> Source/Platform/chromium/public/win/WebThemeEngine.h:85
> +    virtual int getScrollbarArrowSize(int partId) = 0;

the rest of this file seems to juse use "int part", not partId.

is there a particular reason you want this to work only for the scrollbar arrow part IDs? android and linux let you ask for the size of any part

> Source/WebCore/platform/chromium/ScrollbarThemeChromiumWin.cpp:254
> +    bool horz = scrollbar->orientation() == HorizontalScrollbar;
> +    int standardGirth = PlatformSupport::getScrollbarArrowSize(horz ? DFCS_SCROLLLEFT : DFCS_SCROLLUP);

WebKit style is not to abbreviate variable names (and there's no column limit), so I'd expect "horz" into "horizontal"

[James Robinson]

Comment on attachment 148149 [details]
Patch

stupid bugzilla

[Scott Graham]

Created attachment 148159 [details]
Patch

[Scott Graham]

(In reply to comment #5)
> (From update of attachment 148149 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=148149&action=review
> 
> > Source/Platform/chromium/public/win/WebThemeEngine.h:85
> > +    virtual int getScrollbarArrowSize(int partId) = 0;
> 
> the rest of this file seems to juse use "int part", not partId.

Done.

> is there a particular reason you want this to work only for the scrollbar arrow part IDs? android and linux let you ask for the size of any part

Done.

> 
> > Source/WebCore/platform/chromium/ScrollbarThemeChromiumWin.cpp:254
> > +    bool horz = scrollbar->orientation() == HorizontalScrollbar;
> > +    int standardGirth = PlatformSupport::getScrollbarArrowSize(horz ? DFCS_SCROLLLEFT : DFCS_SCROLLUP);
> 
> WebKit style is not to abbreviate variable names (and there's no column limit), so I'd expect "horz" into "horizontal"

Copied from above.

I realized I was using the wrong defines anyway per http://msdn.microsoft.com/en-us/library/windows/desktop/bb773210(v=vs.85).aspx so there's no distinction between horizontal/vertical anyway.

[James Robinson]

Comment on attachment 148159 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148159&action=review

> Source/Platform/chromium/public/win/WebThemeEngine.h:85
> +    virtual int getSize(int part) = 0;

Add a comment saying what the size means and what parts it can be queried for

[Scott Graham]

Created attachment 148166 [details]
Patch

[Scott Graham]

(In reply to comment #9)
> (From update of attachment 148159 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=148159&action=review
> 
> > Source/Platform/chromium/public/win/WebThemeEngine.h:85
> > +    virtual int getSize(int part) = 0;
> 
> Add a comment saying what the size means and what parts it can be queried for

Done. Also made it a WebSize/IntSize because on writing the comment realized it made no sense to be an int.

[James Robinson]

Comment on attachment 148166 [details]
Patch

R=me. Guessing we want to hold off on commit-queue until the chromium side lands, right?

[Scott Graham]

(In reply to comment #12)
> (From update of attachment 148166 [details])
> R=me. Guessing we want to hold off on commit-queue until the chromium side lands, right?

Thanks. Yes, I'll ping you when this is safe to cq+.

[James Robinson]

What chromium rev had the change?  Is it rolled into Source/WebKit/chromium/DEPS in the WebKit repo yet? (I'm cautious since we don't have any cr-win EWS coverage).

[Scott Graham]

(In reply to comment #14)
> What chromium rev had the change?  Is it rolled into Source/WebKit/chromium/DEPS in the WebKit repo yet? (I'm cautious since we don't have any cr-win EWS coverage).

Shoot, you're right. I always forget about the backwards roll.

ftr, http://crrev.com/142993

[James Robinson]

Comment on attachment 148166 [details]
Patch

CQ minus since http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/DEPS shows me 142842. Set cq? when it's ahead.

[Scott Graham]

Comment on attachment 148166 [details]
Patch

143776 now

[WebKit Review Bot]

Comment on attachment 148166 [details]
Patch

Clearing flags on attachment: 148166

Committed r121176: <http://trac.webkit.org/changeset/121176>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

Re-opened since this is blocked by 89934