to add a GCActivityCallbackBlackBerry.cpp, and put our low memory GC policy into didAllocate().
Created attachment 147874 [details] the patch Geoffrey, the patch adds one line to Heap.h: bool isSafeToCollect() const { return m_isSafeToCollect; } Do you think it is OK?
Attachment 147874 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/runtime/GCActivityCallbackBlackBerry.cpp:22: Alphabetical sorting problem. [build/include_order] [4] Source/JavaScriptCore/runtime/GCActivityCallbackBlackBerry.cpp:28: Missing space inside { }. [whitespace/braces] [5] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 147878 [details] fix the style error
Comment on attachment 147878 [details] fix the style error Looks good.
> bool isSafeToCollect() const { return m_isSafeToCollect; } This is fine. Seriously, though, you're making GC on Blackberry O(n^2).
(In reply to comment #5) > > bool isSafeToCollect() const { return m_isSafeToCollect; } > > This is fine. > > Seriously, though, you're making GC on Blackberry O(n^2). It is still using a limit which is just the small one (1MB). I commented the isMemoryLow check and tested it on some heavy sites. It is a bit slower, but seems still OK.
Comment on attachment 147878 [details] fix the style error Clearing flags on attachment: 147878 Committed r120502: <http://trac.webkit.org/changeset/120502>
All reviewed patches have been landed. Closing bug.