Bug 89233 – [chromium] WebFrameClient::userAgentOverride() should take in a WebFrame* as its first argument

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

Missed this the first time, but the function needs to take in a WebFrame* pointer to be consistent with the API.  Adding it now.

Created attachment 147891 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Adam Barth]

Sounds like I should let fishd give the r+ on this one since I goofed it up twice already.  :)

[Darin Fisher (:fishd, Google)]

Comment on attachment 147891 [details]
Patch

Thanks!

[WebKit Review Bot]

Comment on attachment 147891 [details]
Patch

Rejecting attachment 147891 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
  return self.open(self.click(*args, **kwds))
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 203, in open
    return self._mech_open(url, data, timeout=timeout)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 255, in _mech_open
    raise response
webkitpy.thirdparty.autoinstalled.mechanize._response.httperror_seek_wrapper: HTTP Error 500: Internal Server Error

Full output: http://queues.webkit.org/results/12966609

[WebKit Review Bot]

Comment on attachment 147891 [details]
Patch

Clearing flags on attachment: 147891

Committed r120526: <http://trac.webkit.org/changeset/120526>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.