Bug 89233 - [chromium] WebFrameClient::userAgentOverride() should take in a WebFrame* as its first argument
Summary: [chromium] WebFrameClient::userAgentOverride() should take in a WebFrame* as ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: dfalcantara
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-15 11:03 PDT by dfalcantara
Modified: 2012-06-16 02:22 PDT (History)
6 users (show)

See Also:


Attachments
Patch (2.87 KB, patch)
2012-06-15 13:59 PDT, dfalcantara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description dfalcantara 2012-06-15 11:03:59 PDT
Missed this the first time, but the function needs to take in a WebFrame* pointer to be consistent with the API.  Adding it now.
Comment 1 dfalcantara 2012-06-15 13:59:39 PDT
Created attachment 147891 [details]
Patch
Comment 2 WebKit Review Bot 2012-06-15 14:02:31 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Adam Barth 2012-06-15 14:36:08 PDT
Sounds like I should let fishd give the r+ on this one since I goofed it up twice already.  :)
Comment 4 Darin Fisher (:fishd, Google) 2012-06-15 22:14:03 PDT
Comment on attachment 147891 [details]
Patch

Thanks!
Comment 5 WebKit Review Bot 2012-06-16 00:28:23 PDT
Comment on attachment 147891 [details]
Patch

Rejecting attachment 147891 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
  return self.open(self.click(*args, **kwds))
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 203, in open
    return self._mech_open(url, data, timeout=timeout)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 255, in _mech_open
    raise response
webkitpy.thirdparty.autoinstalled.mechanize._response.httperror_seek_wrapper: HTTP Error 500: Internal Server Error

Full output: http://queues.webkit.org/results/12966609
Comment 6 WebKit Review Bot 2012-06-16 02:21:56 PDT
Comment on attachment 147891 [details]
Patch

Clearing flags on attachment: 147891

Committed r120526: <http://trac.webkit.org/changeset/120526>
Comment 7 WebKit Review Bot 2012-06-16 02:22:02 PDT
All reviewed patches have been landed.  Closing bug.