Bug 89227 - [BlackBerry] Disable WebCore::EventHandler synthesized mouse events during touch scrolling
Summary: [BlackBerry] Disable WebCore::EventHandler synthesized mouse events during to...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antonio Gomes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-15 09:45 PDT by Antonio Gomes
Modified: 2012-06-15 11:55 PDT (History)
1 user (show)

See Also:


Attachments
(committed r120482, r=rbuis) patch (5.41 KB, patch)
2012-06-15 11:32 PDT, Antonio Gomes
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Gomes 2012-06-15 09:45:20 PDT
++++++++++++++++++++++++++++++++++++
FROM PRzilla:

I was looking at some odd pattern and discovered that the WebCore::EventHandler
will periodically synthesize mouse events while you scroll. On the desktop, the
mouse cursor remains still while you scroll using mouse wheel, so this seems
correct (the.cursor is moving relative to the page while scrolling, so mouse
move events are in order). But for touch scrolling it seems not only a waste of
battery but also completely wrong, because your finger does not move relative
to the page during touch scrolling, and the synthesized events have the wrong
position.
--------------------------------------
Comment 1 Antonio Gomes 2012-06-15 11:32:48 PDT
Created attachment 147864 [details]
(committed r120482, r=rbuis) patch
Comment 2 Rob Buis 2012-06-15 11:35:40 PDT
Comment on attachment 147864 [details]
(committed r120482, r=rbuis) patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147864&action=review

Looks good.

> Source/WebKit/blackberry/Api/WebSettings.h:76
> +    bool doesDeviceSupportMouse() const;

Instead of doesDeviceSupportMouse you can just do deviceSupportsMouse.
Comment 3 Antonio Gomes 2012-06-15 11:54:53 PDT
Comment on attachment 147864 [details]
(committed r120482, r=rbuis) patch

Committed <http://trac.webkit.org/changeset/120482>