Adds DeviceMotionClientMock
Created attachment 147833 [details] Patch
This looks good to me. Steve, would you like to take a look?
Comment on attachment 147833 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147833&action=review r=me > Source/WebCore/platform/mock/DeviceMotionClientMock.h:52 > + virtual void deviceMotionControllerDestroyed() OVERRIDE { } Maybe add a comment about why we don't need to do anything here
Created attachment 148366 [details] Patch
thanks for the review! (In reply to comment #3) > (From update of attachment 147833 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=147833&action=review > > r=me > > > Source/WebCore/platform/mock/DeviceMotionClientMock.h:52 > > + virtual void deviceMotionControllerDestroyed() OVERRIDE { } > > Maybe add a comment about why we don't need to do anything here Done.
Comment on attachment 148366 [details] Patch Clearing flags on attachment: 148366 Committed r120744: <http://trac.webkit.org/changeset/120744>
All reviewed patches have been landed. Closing bug.
This looks like it broke the Chromium Windows canaries. A sample build failure: http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Win%20Builder/builds/26273 I'm going to roll it out.
Reverted r120744 for reason: Broke build on Chromium Windows canary bots Committed r120748: <http://trac.webkit.org/changeset/120748>
One more example failure, from the build.webkit.org bots: http://build.webkit.org/builders/Chromium%20Win%20Release/builds/45417 . Looks like WebCore\dom\DeviceMotion.h isn't present in the Windows build.
Comment on attachment 148366 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148366&action=review > Source/WebCore/WebCore.gypi:626 > + 'dom/DeviceMotion.h', Sorry, I should have spotted this - it looks like this is leftover from the old all-in-one patchset - and broke the build. > Source/WebCore/WebCore.gypi:627 > + 'dom/DeviceMotionClient.h', Presumably this was erroneously left out of a previous change?
Created attachment 148528 [details] Patch
(In reply to comment #11) > (From update of attachment 148366 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=148366&action=review > > > Source/WebCore/WebCore.gypi:626 > > + 'dom/DeviceMotion.h', > > Sorry, I should have spotted this - it looks like this is leftover from the old all-in-one patchset - and broke the build. Sorry about that - I fixed it in the new attachment. > > Source/WebCore/WebCore.gypi:627 > > + 'dom/DeviceMotionClient.h', > > Presumably this was erroneously left out of a previous change? Yes, I think so, since DeviceMotionClient.h already existed.
Comment on attachment 148528 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148528&action=review > Source/WebCore/WebCore.gypi:627 > + 'dom/DeviceMotionData.h', I guess this one was missing too?
(In reply to comment #14) > (From update of attachment 148528 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=148528&action=review > > > Source/WebCore/WebCore.gypi:627 > > + 'dom/DeviceMotionData.h', > > I guess this one was missing too? Yes, it appears so.
Comment on attachment 148528 [details] Patch r=me
Comment on attachment 148528 [details] Patch Clearing flags on attachment: 148528 Committed r120814: <http://trac.webkit.org/changeset/120814>