Bug 89211 – [BlackBerry] Certain web pages (i.e., http://www.cloudtweaks.com/) are allowed to be wider than the screen

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[Jacky Jiang]

Steps to Reproduce:
*Open Browse
*Go to http://www.cloudtweaks.com/
*Observe that the information are not fitted to the screen - able to scroll
left and right, instead of just up and down

Expected:
*All web pages should fit in to the screen

[Jacky Jiang]

Created attachment 147828 [details]
Patch

[Jacky Jiang]

Comment on attachment 147828 [details]
Patch

Will update the internal reviewer.

[Jacky Jiang]

Created attachment 147829 [details]
committed, r=rwlbuis

[Rob Buis]

Comment on attachment 147829 [details]
committed, r=rwlbuis

View in context: https://bugs.webkit.org/attachment.cgi?id=147829&action=review

LGTM.

> Source/WebKit/blackberry/Api/WebPage.cpp:1683
> +    return zoomToFitScale < minimumZoomToFitScale ? minimumZoomToFitScale : zoomToFitScale;

Using std:min is better here as it is clearer what you are doing.

[Jacky Jiang]

Comment on attachment 147829 [details]
committed, r=rwlbuis

View in context: https://bugs.webkit.org/attachment.cgi?id=147829&action=review

>> Source/WebKit/blackberry/Api/WebPage.cpp:1683
>> +    return zoomToFitScale < minimumZoomToFitScale ? minimumZoomToFitScale : zoomToFitScale;
> 
> Using std:min is better here as it is clearer what you are doing.

Thanks for catching this!  Should use std::max instead of std:min actually.

[Jacky Jiang]

Comment on attachment 147829 [details]
committed, r=rwlbuis

Committed r120473: <http://trac.webkit.org/changeset/120473>.