RESOLVED FIXED 89198
Web Inspector: too many hardcoded strings in InspectorBackendDispatcher. 
https://bugs.webkit.org/show_bug.cgi?id=89198
Summary Web Inspector: too many hardcoded strings in InspectorBackendDispatcher.
Ilya Tikhonovsky
Reported 2012-06-15 05:25:09 PDT
EOM
Attachments
Patch (5.46 KB, patch)
2012-07-05 16:19 PDT, Peter Rybin 		no flags
DetailsFormatted DiffDiff
Patch (5.19 KB, patch)
2012-07-13 03:37 PDT, Peter Rybin 		yurys: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Peter Rybin
Comment 1 2012-07-05 16:19:19 PDT
Created attachment 150997 [details] Patch
Yury Semikhatsky
Comment 2 2012-07-05 23:17:27 PDT
Comment on attachment 150997 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150997&action=review > Source/WebCore/inspector/CodeGeneratorInspector.py:1981 > + size_t length = ARRAY_SIZE(commandNames); It should be WTF_ARRAY_LENGTH(commandNames), not sure why compiler didn't complain about it. Is ARRAY_SIZE defined somewhere in WebKit, I only see 2 places (http://code.google.com/p/chromium/source/search?q=define%5CsARRAY_SIZE+file%3AWebKit&origq=define%5CsARRAY_SIZE+file%3AWebKit&btnG=Search+Trunk), none of which should be visible here?
Peter Rybin
Comment 3 2012-07-13 03:37:25 PDT
Created attachment 152207 [details] Patch
Peter Rybin
Comment 4 2012-07-13 03:44:06 PDT
Comment on attachment 150997 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150997&action=review >> Source/WebCore/inspector/CodeGeneratorInspector.py:1981 >> + size_t length = ARRAY_SIZE(commandNames); > > It should be WTF_ARRAY_LENGTH(commandNames), not sure why compiler didn't complain about it. Is ARRAY_SIZE defined somewhere in WebKit, I only see 2 places (http://code.google.com/p/chromium/source/search?q=define%5CsARRAY_SIZE+file%3AWebKit&origq=define%5CsARRAY_SIZE+file%3AWebKit&btnG=Search+Trunk), none of which should be visible here? Actually I made my own -- didn't know the right name for search. Replaced.
Ilya Tikhonovsky
Comment 5 2012-07-13 07:30:30 PDT
Committed r122574: <http://trac.webkit.org/changeset/122574>
Note You need to log in before you can comment on or make changes to this bug.