This is preparation of splinting RenderTextControlSingline into RenderTextControlSingline and RenderSeatchField (bug 88980).
Created attachment 147705 [details] Patch 1
Comment on attachment 147705 [details] Patch 1 Could you review this patch? Thanks in advance. * Just copy two files
Attachment 147705 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/rendering/RenderSearchField.cpp:25: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Source/WebCore/rendering/RenderSearchField.cpp:26: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/rendering/RenderSearchField.cpp:658: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/WebCore/rendering/RenderSearchField.h:23: #ifndef header guard has wrong style, please use: RenderSearchField_h [build/header_guard] [5] Total errors found: 4 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 147705 [details] Patch 1 ok
Comment on attachment 147705 [details] Patch 1 Clearing flags on attachment: 147705 Committed r120390: <http://trac.webkit.org/changeset/120390>
All reviewed patches have been landed. Closing bug.
Unfortunately we failed. RenderSearchField.cpp doesn't have expected history. http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/RenderSearchField.cpp?annotate=blame&rev=120432
I'm pretty sure you need to give an actual "svn copy" command in order to achieve that. git has no notion of moving/copying files, so what you're doing is copying the contents of the file, rather than the file itself.
(In reply to comment #8) > I'm pretty sure you need to give an actual "svn copy" command in order to achieve that. git has no notion of moving/copying files, so what you're doing is copying the contents of the file, rather than the file itself. Thanks Peter! I'm doing roll out this change.
Reverted r120390 for reason: Failed to copy merge history to RenderSerachField.{cpp,h} Committed r120558: <http://trac.webkit.org/changeset/120558>
Reverted r120565 for reason: Bad message Committed r120566: <http://trac.webkit.org/changeset/120566>
Finally, I could copy history r120567 http://trac.webkit.org/changeset/120567