Bug 89145 - [chromium] GraphicsLayerChromium should use WebContentLayer directly
Summary: [chromium] GraphicsLayerChromium should use WebContentLayer directly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-14 18:08 PDT by James Robinson
Modified: 2012-06-18 16:41 PDT (History)
8 users (show)

See Also:

Attachments
Patch (16.26 KB, patch)
2012-06-14 18:11 PDT, James Robinson 		enne: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2012-06-14 18:08:44 PDT 
[chromium] GraphicsLayerChromium should use WebContentLayer directly
Comment 1 James Robinson 2012-06-14 18:11:18 PDT 
Created attachment 147695 [details]
Patch
Comment 2 James Robinson 2012-06-14 18:11:46 PDT 
I'll have to land a chromium-side patch to ui/compositor/layer.cc to avoid compile breaking chromium - that's what the WEBCONTENTLAYERCLIENT_HAS_OPAQUE #define is for.
Comment 3 Antoine Labour 2012-06-14 18:13:56 PDT 
Comment on attachment 147695 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147695&action=review

> Source/Platform/chromium/public/WebContentLayerClient.h:42
> +    // optimizations.

To be clear, that's only used if !WebLayer.opaque(), right?
Comment 4 WebKit Review Bot 2012-06-14 18:15:01 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 5 James Robinson 2012-06-14 18:15:33 PDT 
(In reply to comment #3)
> (From update of attachment 147695 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=147695&action=review
> 
> > Source/Platform/chromium/public/WebContentLayerClient.h:42
> > +    // optimizations.
> 
> To be clear, that's only used if !WebLayer.opaque(), right?

It's ignored, right.  We don't set it on opaque layers to avoid paying the overhead.
Comment 6 Adrienne Walker 2012-06-15 09:04:07 PDT 
Comment on attachment 147695 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147695&action=review

R=me.

> Source/WebKit/chromium/tests/CCOcclusionTrackerTest.cpp:138
> +        layer->setIsDrawable(false);

Isn't that the default value?
Comment 7 James Robinson 2012-06-15 14:26:59 PDT 
Comment on attachment 147695 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147695&action=review

>> Source/WebKit/chromium/tests/CCOcclusionTrackerTest.cpp:138
>> +        layer->setIsDrawable(false);
> 
> Isn't that the default value?

Ooh, good point.  This was a bad intermediate state from when I was playing with the default value - will revert before landing.
Comment 8 James Robinson 2012-06-18 16:41:32 PDT 
Committed r120643: <http://trac.webkit.org/changeset/120643>