Bug 89145 – [chromium] GraphicsLayerChromium should use WebContentLayer directly

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[James Robinson]

[chromium] GraphicsLayerChromium should use WebContentLayer directly

[James Robinson]

Created attachment 147695 [details]
Patch

[James Robinson]

I'll have to land a chromium-side patch to ui/compositor/layer.cc to avoid compile breaking chromium - that's what the WEBCONTENTLAYERCLIENT_HAS_OPAQUE #define is for.

[Antoine Labour]

Comment on attachment 147695 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147695&action=review

> Source/Platform/chromium/public/WebContentLayerClient.h:42
> +    // optimizations.

To be clear, that's only used if !WebLayer.opaque(), right?

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[James Robinson]

(In reply to comment #3)
> (From update of attachment 147695 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=147695&action=review
> 
> > Source/Platform/chromium/public/WebContentLayerClient.h:42
> > +    // optimizations.
> 
> To be clear, that's only used if !WebLayer.opaque(), right?

It's ignored, right.  We don't set it on opaque layers to avoid paying the overhead.

[Adrienne Walker]

Comment on attachment 147695 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147695&action=review

R=me.

> Source/WebKit/chromium/tests/CCOcclusionTrackerTest.cpp:138
> +        layer->setIsDrawable(false);

Isn't that the default value?

[James Robinson]

Comment on attachment 147695 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147695&action=review

>> Source/WebKit/chromium/tests/CCOcclusionTrackerTest.cpp:138
>> +        layer->setIsDrawable(false);
> 
> Isn't that the default value?

Ooh, good point.  This was a bad intermediate state from when I was playing with the default value - will revert before landing.

[James Robinson]

Committed r120643: <http://trac.webkit.org/changeset/120643>