Bug 89141 - [Chromium] Check the result of FontCache::getCachedFontPlatformData()
Summary: [Chromium] Check the result of FontCache::getCachedFontPlatformData()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kenichi Ishibashi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-14 17:27 PDT by Kenichi Ishibashi
Modified: 2012-06-14 22:56 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.96 KB, patch)
2012-06-14 17:33 PDT, Kenichi Ishibashi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenichi Ishibashi 2012-06-14 17:27:05 PDT 
The function essentially returns the result of FontCache::createFontPlatformData(), which can be null. We should check the value before dereference.

Detail: http://crbug.com/131004
Comment 1 Kenichi Ishibashi 2012-06-14 17:33:02 PDT 
Created attachment 147688 [details]
Patch
Comment 2 Kenichi Ishibashi 2012-06-14 17:36:22 PDT 
Hi tony, kent-san,

Could you take a look? I can't come up with a way to test this change because the problem depends on the settings of fontconfig and the problem won't occur with DRT.
Comment 3 Kent Tamura 2012-06-14 21:38:13 PDT 
Comment on attachment 147688 [details]
Patch

Looks ok
Comment 4 Kenichi Ishibashi 2012-06-14 21:41:17 PDT 
Comment on attachment 147688 [details]
Patch

Thanks!
Comment 5 WebKit Review Bot 2012-06-14 22:55:58 PDT 
Comment on attachment 147688 [details]
Patch

Clearing flags on attachment: 147688

Committed r120402: <http://trac.webkit.org/changeset/120402>
Comment 6 WebKit Review Bot 2012-06-14 22:56:02 PDT 
All reviewed patches have been landed.  Closing bug.