Bug 8914 - "border-collapse: collapse;" for table removes part of its border (was: Border disappears when close to some elements)
Summary: "border-collapse: collapse;" for table removes part of its border (was: Borde...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P3 Normal
Assignee: Robert Hogan
URL: http://www.fondazionebernardinodelboc...
Keywords: HasReduction
Depends on:
Blocks:
 
Reported: 2006-05-15 01:27 PDT by Morten Norby Larsen
Modified: 2015-03-26 21:18 PDT (History)
16 users (show)

See Also:

Attachments
Test case reduction (607 bytes, text/html)
2006-05-15 04:58 PDT, jonathanjohnsson 		no flags Details
A test case for this bug. The bottom border of a table disappears if it is absolutely positioned, uses box-sizing:border-box, border-collapse:collapse, and overflow:hidden. (31 bytes, text/plain)
2013-01-29 11:09 PST, Phil 		no flags Details
Patch (9.07 KB, patch)
2013-07-18 12:02 PDT, Robert Hogan 		no flags Details | Formatted Diff | Diff
Patch (10.73 KB, patch)
2013-08-12 12:06 PDT, Robert Hogan 		no flags Details | Formatted Diff | Diff
Patch (10.74 KB, patch)
2013-08-12 14:35 PDT, Robert Hogan 		no flags Details | Formatted Diff | Diff
Patch (25.77 KB, patch)
2013-09-04 11:04 PDT, Robert Hogan 		no flags Details | Formatted Diff | Diff
Patch (25.72 KB, patch)
2013-09-04 11:20 PDT, Robert Hogan 		no flags Details | Formatted Diff | Diff
Patch (25.69 KB, patch)
2013-10-15 11:58 PDT, Robert Hogan 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Morten Norby Larsen 2006-05-15 01:27:29 PDT 
The gray border around the white upper part is not fully drawn.
Comment 1 jonathanjohnsson 2006-05-15 04:58:55 PDT 
Created attachment 8315 [details]
Test case reduction

The problem here is "border-collapse: collapse" for the table.
Comment 2 jonathanjohnsson 2006-05-15 05:05:06 PDT 
I don't know what "border-collapse: collapse;" does in general, or should do in this case. At least Safari and Firefox render it differently.

I searched and found some other bugs related to collapsing in tables, but I don't know if this is a duplicate of any of them.
Comment 3 Joost de Valk (AlthA) 2006-05-15 05:14:13 PDT 
Can't see a direct dupe here, but this is definitly wrong... Firefox renders it correctly IMHO.
Comment 4 Morten Norby Larsen 2009-09-11 09:35:56 PDT 
Also reproducible in r48276.
Comment 5 Phil 2013-01-29 11:09:14 PST 
Created attachment 185270 [details]
A test case for this bug.  The bottom border of a table disappears if it is absolutely positioned, uses box-sizing:border-box, border-collapse:collapse, and overflow:hidden.
Comment 6 Phil 2013-01-29 11:11:17 PST 
Here's an additional test case for this bug: https://gist.github.com/4666558

The bottom border of a table disappears if it is absolutely positioned, uses box-sizing:border-box, border-collapse:collapse, and overflow:hidden.
Comment 7 Yuki Sekiguchi 2013-06-04 23:10:27 PDT 
I'll talk about the original content.

RenderTableCell draws collapsed border in WebKit.
In the content, there is no RenderTableCell at upper-right or lower-right of a table.
Since there is no RenderTableCell, we cannot draw borders of the corners.
Comment 8 Yuki Sekiguchi 2013-06-04 23:20:12 PDT 
Hi Phil,

(In reply to comment #6)
> Here's an additional test case for this bug: https://gist.github.com/4666558
> 
> The bottom border of a table disappears if it is absolutely positioned, uses box-sizing:border-box, border-collapse:collapse, and overflow:hidden.

This content have different bug from this bug.
I created a new bug for this content.
Please watch Bug 117226, if you interested in.
Comment 9 Robert Hogan 2013-07-18 12:02:28 PDT 
Created attachment 207010 [details]
Patch
Comment 10 Dave Hyatt 2013-08-06 13:34:08 PDT 
Comment on attachment 207010 [details]
Patch

If I'm understanding the comment correctly, you're letting both the row group and cell paint the same border? That doesn't work when transparency is involved, e.g., rgba colors.
Comment 11 Robert Hogan 2013-08-12 12:06:18 PDT 
Created attachment 208553 [details]
Patch
Comment 12 EFL EWS Bot 2013-08-12 12:24:20 PDT 
Comment on attachment 208553 [details]
Patch

Attachment 208553 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1459106
Comment 13 EFL EWS Bot 2013-08-12 12:33:44 PDT 
Comment on attachment 208553 [details]
Patch

Attachment 208553 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1449253
Comment 14 Build Bot 2013-08-12 12:48:40 PDT 
Comment on attachment 208553 [details]
Patch

Attachment 208553 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1456149
Comment 15 Build Bot 2013-08-12 13:23:19 PDT 
Comment on attachment 208553 [details]
Patch

Attachment 208553 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1446401
Comment 16 Robert Hogan 2013-08-12 14:35:27 PDT 
Created attachment 208564 [details]
Patch
Comment 17 Robert Hogan 2013-09-04 11:04:31 PDT 
Created attachment 210475 [details]
Patch
Comment 18 Build Bot 2013-09-04 11:11:35 PDT 
Comment on attachment 210475 [details]
Patch

Attachment 210475 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1693678
Comment 19 Build Bot 2013-09-04 11:13:02 PDT 
Comment on attachment 210475 [details]
Patch

Attachment 210475 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1697330
Comment 20 Robert Hogan 2013-09-04 11:20:04 PDT 
Created attachment 210478 [details]
Patch
Comment 21 Dave Hyatt 2013-10-14 13:50:45 PDT 
Comment on attachment 210478 [details]
Patch

r=me
Comment 22 WebKit Commit Bot 2013-10-15 11:48:03 PDT 
Comment on attachment 210478 [details]
Patch

Rejecting attachment 210478 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 210478, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
e LayoutTests/fast/table/paint-section-borders-without-cells-vertical-lr.html
patching file LayoutTests/fast/table/paint-section-borders-without-cells-vertical-rl-expected.html
patching file LayoutTests/fast/table/paint-section-borders-without-cells-vertical-rl.html
patching file LayoutTests/fast/table/paint-section-borders-without-cells.html

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'David Hyatt']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/4105018
Comment 23 Robert Hogan 2013-10-15 11:58:34 PDT 
Created attachment 214289 [details]
Patch
Comment 24 WebKit Commit Bot 2013-10-17 10:42:44 PDT 
Comment on attachment 214289 [details]
Patch

Clearing flags on attachment: 214289

Committed r157579: <http://trac.webkit.org/changeset/157579>
Comment 25 WebKit Commit Bot 2013-10-17 10:42:47 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 26 Simon Fraser (smfr) 2015-03-26 21:18:18 PDT 
I think this caused a quite severe regression in scrolling tables inside overflow:scroll.