Bug 8914 – "border-collapse: collapse;" for table removes part of its border (was: Border disappears when close to some elements)

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Morten Norby Larsen]

The gray border around the white upper part is not fully drawn.

Created attachment 8315 [details]
Test case reduction

The problem here is "border-collapse: collapse" for the table.

I don't know what "border-collapse: collapse;" does in general, or should do in this case. At least Safari and Firefox render it differently.

I searched and found some other bugs related to collapsing in tables, but I don't know if this is a duplicate of any of them.

[Joost de Valk (AlthA)]

Can't see a direct dupe here, but this is definitly wrong... Firefox renders it correctly IMHO.

[Morten Norby Larsen]

Also reproducible in r48276.

[Phil]

Created attachment 185270 [details]
A test case for this bug.  The bottom border of a table disappears if it is absolutely positioned, uses box-sizing:border-box, border-collapse:collapse, and overflow:hidden.

[Phil]

Here's an additional test case for this bug: https://gist.github.com/4666558

The bottom border of a table disappears if it is absolutely positioned, uses box-sizing:border-box, border-collapse:collapse, and overflow:hidden.

[Yuki Sekiguchi]

I'll talk about the original content.

RenderTableCell draws collapsed border in WebKit.
In the content, there is no RenderTableCell at upper-right or lower-right of a table.
Since there is no RenderTableCell, we cannot draw borders of the corners.

[Yuki Sekiguchi]

Hi Phil,

(In reply to comment #6)
> Here's an additional test case for this bug: https://gist.github.com/4666558
> 
> The bottom border of a table disappears if it is absolutely positioned, uses box-sizing:border-box, border-collapse:collapse, and overflow:hidden.

This content have different bug from this bug.
I created a new bug for this content.
Please watch Bug 117226, if you interested in.

[Robert Hogan]

Created attachment 207010 [details]
Patch

[Dave Hyatt]

Comment on attachment 207010 [details]
Patch

If I'm understanding the comment correctly, you're letting both the row group and cell paint the same border? That doesn't work when transparency is involved, e.g., rgba colors.

[Robert Hogan]

Created attachment 208553 [details]
Patch

[EFL EWS Bot]

Comment on attachment 208553 [details]
Patch

Attachment 208553 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1459106

[EFL EWS Bot]

Comment on attachment 208553 [details]
Patch

Attachment 208553 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1449253

[Build Bot]

Comment on attachment 208553 [details]
Patch

Attachment 208553 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1456149

[Build Bot]

Comment on attachment 208553 [details]
Patch

Attachment 208553 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1446401

[Robert Hogan]

Created attachment 208564 [details]
Patch

[Robert Hogan]

Created attachment 210475 [details]
Patch

[Build Bot]

Comment on attachment 210475 [details]
Patch

Attachment 210475 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1693678

[Build Bot]

Comment on attachment 210475 [details]
Patch

Attachment 210475 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1697330

[Robert Hogan]

Created attachment 210478 [details]
Patch

[Dave Hyatt]

Comment on attachment 210478 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 210478 [details]
Patch

Rejecting attachment 210478 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 210478, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
e LayoutTests/fast/table/paint-section-borders-without-cells-vertical-lr.html
patching file LayoutTests/fast/table/paint-section-borders-without-cells-vertical-rl-expected.html
patching file LayoutTests/fast/table/paint-section-borders-without-cells-vertical-rl.html
patching file LayoutTests/fast/table/paint-section-borders-without-cells.html

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'David Hyatt']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/4105018

[Robert Hogan]

Created attachment 214289 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 214289 [details]
Patch

Clearing flags on attachment: 214289

Committed r157579: <http://trac.webkit.org/changeset/157579>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Simon Fraser (smfr)]

I think this caused a quite severe regression in scrolling tables inside overflow:scroll.