Bug 89127 - Fix framebuffer completeness test
Summary: Fix framebuffer completeness test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Gregg Tavares
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-14 14:54 PDT by Gregg Tavares
Modified: 2012-06-14 22:54 PDT (History)
3 users (show)

See Also:

Attachments
Patch (10.48 KB, patch)
2012-06-14 14:55 PDT, Gregg Tavares 		no flags Details | Formatted Diff | Diff
Patch (16.36 KB, patch)
2012-06-14 15:43 PDT, Gregg Tavares 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gregg Tavares 2012-06-14 14:54:46 PDT 
Fix framebuffer completeness test
Comment 1 Gregg Tavares 2012-06-14 14:55:22 PDT 
Created attachment 147657 [details]
Patch
Comment 2 Gregg Tavares 2012-06-14 15:43:11 PDT 
Created attachment 147665 [details]
Patch
Comment 3 Gregg Tavares 2012-06-14 15:44:08 PDT 
The old code disallowed DEPTH_STENCIL attachments so I needed to update the expectations
Comment 4 Zhenyao Mo 2012-06-14 16:17:27 PDT 
LGTM, thanks for fixing this.
Comment 5 Kenneth Russell 2012-06-14 17:44:10 PDT 
Comment on attachment 147665 [details]
Patch

r=me based on Mo's review.
Comment 6 WebKit Review Bot 2012-06-14 22:54:09 PDT 
Comment on attachment 147665 [details]
Patch

Clearing flags on attachment: 147665

Committed r120401: <http://trac.webkit.org/changeset/120401>
Comment 7 WebKit Review Bot 2012-06-14 22:54:13 PDT 
All reviewed patches have been landed.  Closing bug.