Bug 89126 - [chromium] Fix LayoutTests/platform/chromium/compositing/accelerated-drawing/svg-filters.html
Summary: [chromium] Fix LayoutTests/platform/chromium/compositing/accelerated-drawing/...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-14 13:55 PDT by James Robinson
Modified: 2012-06-15 15:24 PDT (History)
3 users (show)

See Also:


Attachments
Patch (4.67 KB, patch)
2012-06-14 14:19 PDT, James Robinson
senorblanco: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2012-06-14 13:55:08 PDT
[chromium] Fix LayoutTests/platform/chromium/compositing/accelerated-drawing/svg-filters.html
Comment 1 James Robinson 2012-06-14 14:19:09 PDT
Created attachment 147651 [details]
Patch
Comment 2 Stephen White 2012-06-15 06:51:24 PDT
Comment on attachment 147651 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147651&action=review

Thanks for fixing this.  r=me

> Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp:179
> +    // If we're rendering into a deferred device, we need to make a deep copy of the source pixels because Skia does not
> +    // retain a reference to the actual pixels otherwise. We check if we're drawing into a deferred device by seeing if the

Nit:  Technically, it's a deferred canvas, not a deferred device (SkPicture::beginRecording() returns an SkPictureRecord, which is a subclass of SkCanvas).
Comment 3 James Robinson 2012-06-15 13:08:04 PDT
Gotcha, I'll fix the comment before landing. Thanks!
Comment 4 James Robinson 2012-06-15 15:24:20 PDT
Committed r120501: <http://trac.webkit.org/changeset/120501>