Fix bit packing of StyleRareInheritedData on Windows
Created attachment 147614 [details] Patch
Comment on attachment 147614 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147614&action=review > Source/WebCore/rendering/style/StyleRareInheritedData.cpp:44 > + unsigned m_bitfields[2]; > + > + Color colors[6]; > + float floats[2]; > + void* ownPtrs[1]; > + AtomicString atomicStrings[5]; > + void* refPtrs[2]; > + Length lengths[1]; > + short pagedMediaShorts[2]; > + unsigned unsigneds[1]; > + short hyphenationShorts[3]; I would be very careful with the order in which these things appear. e.g. unsigned a; void* b; unsigned c; and unsigned a; unsigned b; void* c will consume a different size on a 64-bit architecture.
(In reply to comment #2) > (From update of attachment 147614 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=147614&action=review > > > Source/WebCore/rendering/style/StyleRareInheritedData.cpp:44 > > + unsigned m_bitfields[2]; > > + > > + Color colors[6]; > > + float floats[2]; > > + void* ownPtrs[1]; > > + AtomicString atomicStrings[5]; > > + void* refPtrs[2]; > > + Length lengths[1]; > > + short pagedMediaShorts[2]; > > + unsigned unsigneds[1]; > > + short hyphenationShorts[3]; > > I would be very careful with the order in which these things appear. > e.g. > unsigned a; > void* b; > unsigned c; > and > unsigned a; > unsigned b; > void* c > will consume a different size on a 64-bit architecture. Hmm, you're right. I think it's an accident that these match. I'm going to reorder the test values. I bet we can save some memory by reordering some values, but I'll do that in a follow up patch.
Created attachment 147625 [details] Patch for landing
Comment on attachment 147625 [details] Patch for landing Clearing flags on attachment: 147625 Committed r120366: <http://trac.webkit.org/changeset/120366>
All reviewed patches have been landed. Closing bug.