RESOLVED FIXED 89101
Web Inspector: refactor settings screen to move user agent and experiments out of general tab. 
https://bugs.webkit.org/show_bug.cgi?id=89101
Summary Web Inspector: refactor settings screen to move user agent and experiments ou...
Pavel Feldman
Reported 2012-06-14 07:27:28 PDT
See screenshot attached.
Attachments
[IMAGE] with patch applied (66.33 KB, image/png)
2012-06-14 07:27 PDT, Pavel Feldman 		no flags
Details
Patch (37.25 KB, patch)
2012-06-14 07:30 PDT, Pavel Feldman 		vsevik: review+
DetailsFormatted DiffDiff
[SettingsScreen.js] (30.88 KB, application/javascript)
2012-06-14 07:31 PDT, Pavel Feldman 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2012-06-14 07:27:55 PDT
Created attachment 147582 [details] [IMAGE] with patch applied
Pavel Feldman
Comment 2 2012-06-14 07:30:45 PDT
Created attachment 147583 [details] Patch
Pavel Feldman
Comment 3 2012-06-14 07:31:21 PDT
Created attachment 147584 [details] [SettingsScreen.js]
Vsevolod Vlasov
Comment 4 2012-06-14 08:06:44 PDT
Comment on attachment 147583 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147583&action=review > Source/WebCore/inspector/front-end/SettingsScreen.js:46 > + this._tabbedPane.headerContentsElement.insertBefore(this._createCloseButton(), this._tabbedPane.headerContentsElement.firstChild); After this change it is quite possible that this._tabbedPane.headerContentsElement.offsetWidth is not big enough for all tabs. Consider setting shrinkableTabs on tabbedPane and making sure all necessary resize/calculations are done properly.
Vsevolod Vlasov
Comment 5 2012-06-14 08:07:28 PDT
Comment on attachment 147583 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147583&action=review > Source/WebCore/inspector/front-end/SettingsScreen.js:306 > + _updateScriptDisabledCheckbox: function() Please remove the duplicate of this method below.
Pavel Feldman
Comment 6 2012-06-14 09:49:28 PDT
Committed r120331: <http://trac.webkit.org/changeset/120331>
Note You need to log in before you can comment on or make changes to this bug.