Bug 89093 - Remove volume thumb for videos without audio track for Chrome Video controls
Summary: Remove volume thumb for videos without audio track for Chrome Video controls
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Silvia Pfeiffer
URL:
Keywords:
Depends on:
Blocks: 84672 89050
  Show dependency tree / graph
 
Reported: 2012-06-14 06:26 PDT by Silvia Pfeiffer
Modified: 2012-06-15 11:00 PDT (History)
7 users (show)

See Also:

Attachments
complete patch for linux-ews layout tests (25.34 KB, patch)
2012-06-14 06:31 PDT, Silvia Pfeiffer 		no flags Details | Formatted Diff | Diff
Use this for review (6.57 KB, patch)
2012-06-14 06:32 PDT, Silvia Pfeiffer 		no flags Details | Formatted Diff | Diff
patch for cq - also includes image change for elements without audio (4.11 KB, patch)
2012-06-14 19:26 PDT, Silvia Pfeiffer 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Silvia Pfeiffer 2012-06-14 06:26:33 PDT 
This patch is part of the introduction of the new Chromium video controls, master bug at https://bugs.webkit.org/show_bug.cgi?id=84672 . It removes the volume thumb for video and audio elements that have no audio track or have no media resource.
Comment 1 Silvia Pfeiffer 2012-06-14 06:31:46 PDT 
Created attachment 147571 [details]
complete patch for linux-ews layout tests
Comment 2 Silvia Pfeiffer 2012-06-14 06:32:57 PDT 
Created attachment 147572 [details]
Use this for review
Comment 3 Eric Carlson 2012-06-14 09:49:32 PDT 
Comment on attachment 147572 [details]
Use this for review

View in context: https://bugs.webkit.org/attachment.cgi?id=147572&action=review

Looks fine except for the ChangeLog.

> Source/WebCore/ChangeLog:7
>  2012-06-14  Silvia Pfeiffer  <silviapf@chromium.org>
>  
> -        Add fullscreen button to Chrome video controls for video.
> -        https://bugs.webkit.org/show_bug.cgi?id=88818
> +        Remove volume thumb for videos without audio track.
> +        https://bugs.webkit.org/show_bug.cgi?id=89093
>  
>          Reviewed by NOBODY (OOPS!).
>  

Clearly something went wrong when this ChangeLog was generated :-)
Comment 4 Silvia Pfeiffer 2012-06-14 19:26:32 PDT 
Created attachment 147711 [details]
patch for cq - also includes image change for elements without audio
Comment 5 WebKit Review Bot 2012-06-15 11:00:05 PDT 
Comment on attachment 147711 [details]
patch for cq - also includes image change for elements without audio

Clearing flags on attachment: 147711

Committed r120478: <http://trac.webkit.org/changeset/120478>
Comment 6 WebKit Review Bot 2012-06-15 11:00:10 PDT 
All reviewed patches have been landed.  Closing bug.