Bug 89091 - [BlackBerry] empty plugin cause browser hang
Summary: [BlackBerry] empty plugin cause browser hang
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mary Wu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-14 04:57 PDT by Mary Wu
Modified: 2012-06-14 22:24 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.74 KB, patch)
2012-06-14 05:17 PDT, Mary Wu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mary Wu 2012-06-14 04:57:29 PDT
related to empty plugin, click an empty "*.swf" link, it launch flash plugin, and shows blank page since no content. however when go back and click other links on the page, it hangs. It's because FrameLoaderBlackBerry didn't check its content when clear m_pluginView.
Comment 1 Mary Wu 2012-06-14 05:17:51 PDT
Created attachment 147560 [details]
Patch
Comment 2 Rob Buis 2012-06-14 07:20:20 PDT
Comment on attachment 147560 [details]
Patch

LGTM. Should the actual hang be checked as well? I am not sure why calling m_pluginView->didFinishLoading should cause a hang.
Comment 3 Mary Wu 2012-06-14 19:09:36 PDT
(In reply to comment #2)
> (From update of attachment 147560 [details])
> LGTM. Should the actual hang be checked as well? I am not sure why calling m_pluginView->didFinishLoading should cause a hang.

in PlugView.cpp, m_pluginView->didFinishLoading will call "m_manualStream->didFinishLoading(0);" without checking if m_manualStream is null or not. m_manualStream was created in didReceiveResponse which won't be hit for empty plugin. Add check m_hasSentResponseToPlugin before finishLoading so it won't core dump in such case.
Comment 4 WebKit Review Bot 2012-06-14 22:24:40 PDT
Comment on attachment 147560 [details]
Patch

Clearing flags on attachment: 147560

Committed r120399: <http://trac.webkit.org/changeset/120399>
Comment 5 WebKit Review Bot 2012-06-14 22:24:44 PDT
All reviewed patches have been landed.  Closing bug.