Bug 89079 - new-run-webkit-websocketserver must handle TLS related arguments
Summary: new-run-webkit-websocketserver must handle TLS related arguments
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Takashi Toyoshima
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-14 01:57 PDT by Takashi Toyoshima
Modified: 2012-06-14 11:07 PDT (History)
6 users (show)

See Also:


Attachments
Patch (4.01 KB, patch)
2012-06-14 02:04 PDT, Takashi Toyoshima
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Takashi Toyoshima 2012-06-14 01:57:50 PDT
Currently, new-run-webkit-websocketserver ignores TLS related arguments, -k and -c.
Also we need to support --ca-certificate for client certificate authentication.
Comment 1 Takashi Toyoshima 2012-06-14 02:04:35 PDT
Created attachment 147522 [details]
Patch
Comment 2 Kenichi Ishibashi 2012-06-14 02:27:21 PDT
Comment on attachment 147522 [details]
Patch

LGTM. We don't need to modify NRWT?
Comment 3 Takashi Toyoshima 2012-06-14 03:12:45 PDT
Currently, I have no plan to use this feature from usual layout tests on NRWT.
In the case of Chromium port, we use new-run-webkit-websocketserver from some unit tests.
This is my major motivation to modify new-run-webkit-websocketserver now.
Also this change will help some new client certificate layout tests in the future.
Comment 4 Kenichi Ishibashi 2012-06-14 05:47:13 PDT
(In reply to comment #3)
> Currently, I have no plan to use this feature from usual layout tests on NRWT.
> In the case of Chromium port, we use new-run-webkit-websocketserver from some unit tests.
> This is my major motivation to modify new-run-webkit-websocketserver now.
> Also this change will help some new client certificate layout tests in the future.

I see. Thank you for explanation :)
Comment 5 Dirk Pranke 2012-06-14 10:26:42 PDT
Comment on attachment 147522 [details]
Patch

looks fine.
Comment 6 WebKit Review Bot 2012-06-14 11:06:58 PDT
Comment on attachment 147522 [details]
Patch

Clearing flags on attachment: 147522

Committed r120342: <http://trac.webkit.org/changeset/120342>
Comment 7 WebKit Review Bot 2012-06-14 11:07:03 PDT
All reviewed patches have been landed.  Closing bug.