Please see the going discussion on the spec side: https://www.w3.org/Bugs/Public/show_bug.cgi?id=17090 We have to adopt a new algorithm once we agree on the new behavior of event re-targeting on the Shadow DOM spec.
Created attachment 147520 [details] WIP. concept of a new re-targeting algorithm
Comment on attachment 147520 [details] WIP. concept of a new re-targeting algorithm I haven't dug into this deeply, but from the first glance, this looks great!
Created attachment 148436 [details] target can now be a distributed node
Created attachment 148820 [details] minor update on changelog
Created attachment 148821 [details] minor update on changelog
Since it got r+ for https://bugs.webkit.org/attachment.cgi?id=148820&action=review, let me land this manually.
Created attachment 148825 [details] Patch for landing
Created attachment 148826 [details] Patch for landing
Comment on attachment 148826 [details] Patch for landing Clearing flags on attachment: 148826 Committed r120945: <http://trac.webkit.org/changeset/120945>
All reviewed patches have been landed. Closing bug.
Re-opened since this is blocked by 89703
*** Bug 89708 has been marked as a duplicate of this bug. ***
I've investigated the crash of editing/shadow/breaking-editing-boundaries.html. It seems this re-targeting patch is innocent. This patch just revealed a bogus DOM structure that was caused in editing/shadow/breaking-editing-boundaries.html. So it seems an editing bug. Let me investigate further.
It seems parentTreeScope() returns an unexpected node. And I found this bug. https://bugs.webkit.org/show_bug.cgi?id=89172 That's the root cause. (In reply to comment #13) > I've investigated the crash of editing/shadow/breaking-editing-boundaries.html. > > It seems this re-targeting patch is innocent. This patch just revealed a bogus DOM structure that was caused in editing/shadow/breaking-editing-boundaries.html. > > So it seems an editing bug. Let me investigate further.
I'll re-land this patch once bug 89172 is resolved. (In reply to comment #14) > It seems parentTreeScope() returns an unexpected node. > And I found this bug. https://bugs.webkit.org/show_bug.cgi?id=89172 > That's the root cause. > > (In reply to comment #13) > > I've investigated the crash of editing/shadow/breaking-editing-boundaries.html. > > > > It seems this re-targeting patch is innocent. This patch just revealed a bogus DOM structure that was caused in editing/shadow/breaking-editing-boundaries.html. > > > > So it seems an editing bug. Let me investigate further.
Created attachment 149045 [details] Patch for landing
Let me re-land this patch since bug 89172 was resolved and confirmed that editing/shadow/breaking-editing-boundaries.html does not crash anymore.
Comment on attachment 149045 [details] Patch for landing Clearing flags on attachment: 149045 Committed r121040: <http://trac.webkit.org/changeset/121040>