This is in preparation for supporting tick marks for datalist for input type=range.
Created attachment 147500 [details] Patch
Created attachment 147503 [details] Patch
Comment on attachment 147500 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147500&action=review > LayoutTests/ChangeLog:28 > + * platform/mac/fast/forms/range/slider-thumb-stylability-expected.png: I don't think this change is necessary. > LayoutTests/fast/forms/range/slider-zoomed-expected.txt:2 > -PASS: slider value set to 72 > +FAIL: expected slider value 72, got 71 I don't think this change is valid. > LayoutTests/platform/chromium-linux/fast/forms/range/slider-thumb-stylability-expected.txt:2 > +layer at (0,0) size 800x600 > + RenderView at (0,0) size 800x600 Why do we need to update the whole file? > LayoutTests/platform/chromium-win/fast/forms/range/slider-thumb-stylability-expected.txt:1 > +layer at (0,0) size 800x600 ditto.
(In reply to comment #3) > > LayoutTests/platform/chromium-linux/fast/forms/range/slider-thumb-stylability-expected.txt:2 > > +layer at (0,0) size 800x600 > > + RenderView at (0,0) size 800x600 > > Why do we need to update the whole file? > > > LayoutTests/platform/chromium-win/fast/forms/range/slider-thumb-stylability-expected.txt:1 > > +layer at (0,0) size 800x600 > > ditto. Oh, I understand. The colors are different in platforms. So we can't share some test results.
Created attachment 147556 [details] Patch
(In reply to comment #3) > (From update of attachment 147500 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=147500&action=review > > > LayoutTests/ChangeLog:28 > > + * platform/mac/fast/forms/range/slider-thumb-stylability-expected.png: > > I don't think this change is necessary. Removed. > > LayoutTests/fast/forms/range/slider-zoomed-expected.txt:2 > > -PASS: slider value set to 72 > > +FAIL: expected slider value 72, got 71 > > I don't think this change is valid. Removed. > > LayoutTests/platform/chromium-linux/fast/forms/range/slider-thumb-stylability-expected.txt:2 > > +layer at (0,0) size 800x600 > > + RenderView at (0,0) size 800x600 > > Why do we need to update the whole file? > > > LayoutTests/platform/chromium-win/fast/forms/range/slider-thumb-stylability-expected.txt:1 > > +layer at (0,0) size 800x600 > > ditto. > > Oh, I understand. The colors are different in platforms. So we can't share some test results. Yes.
Comment on attachment 147556 [details] Patch ok. Please watch the buildbots and take care of test failures when you land the patch.
Comment on attachment 147556 [details] Patch Attachment 147556 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12956445 New failing tests: fast/repaint/slider-thumb-float.html fast/dom/HTMLInputElement/input-slider-update.html fast/dom/HTMLInputElement/input-slider-update-styled.html fast/repaint/slider-thumb-drag-release.html
Created attachment 147646 [details] Archive of layout-test-results from ec2-cr-linux-03 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Created attachment 147738 [details] Patch
Comment on attachment 147738 [details] Patch Clearing flags on attachment: 147738 Committed r120411: <http://trac.webkit.org/changeset/120411>
All reviewed patches have been landed. Closing bug.
This broke several tests on Mac, e.g. http://build.webkit.org/results/Apple%20Lion%20Debug%20WK1%20(Tests)/r120468%20(115)/fast/forms/box-shadow-override-pretty-diff.html
(In reply to comment #13) > This broke several tests on Mac, e.g. > http://build.webkit.org/results/Apple%20Lion%20Debug%20WK1%20(Tests)/r120468%20(115)/fast/forms/box-shadow-override-pretty-diff.html I'm terribly sorry. Thank you for rebaselining.