RESOLVED FIXED Bug 89066
Web Inspector: LayoutTest http/tests/inspector/filesystem/* should clean up FileSystem after test.
https://bugs.webkit.org/show_bug.cgi?id=89066
Summary Web Inspector: LayoutTest http/tests/inspector/filesystem/* should clean up F...
Taiju Tsuiki
Reported 2012-06-13 23:33:10 PDT
http/tests/inspector/filesystem/read-directory.html leaves some file on FileSystem after test. This causes unexpected error on other FileSystem tests on same DRT instance.
Attachments
Patch (5.12 KB, patch)
2012-06-13 23:35 PDT, Taiju Tsuiki
no flags
Taiju Tsuiki
Comment 1 2012-06-13 23:35:30 PDT
Vsevolod Vlasov
Comment 2 2012-06-14 06:40:29 PDT
Comment on attachment 147498 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147498&action=review > LayoutTests/http/tests/inspector/filesystem/filesystem-test.js:59 > + testRunner.evaluateInWebInspector(999, "InspectorTest.dispatchCallback(unescape(\"" + escape(args) + "\"))"); Why did 0 change to 999?
Taiju Tsuiki
Comment 3 2012-06-14 20:29:12 PDT
Comment on attachment 147498 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147498&action=review >> LayoutTests/http/tests/inspector/filesystem/filesystem-test.js:59 >> + testRunner.evaluateInWebInspector(999, "InspectorTest.dispatchCallback(unescape(\"" + escape(args) + "\"))"); > > Why did 0 change to 999? This is callId of the evaluation and callId == 0 is used as runTestCallId in inspector-test.js. I'd like to avoid using same ID here.
WebKit Review Bot
Comment 4 2012-06-15 02:33:28 PDT
Comment on attachment 147498 [details] Patch Clearing flags on attachment: 147498 Committed r120430: <http://trac.webkit.org/changeset/120430>
WebKit Review Bot
Comment 5 2012-06-15 02:33:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.