Bug 89066 - Web Inspector: LayoutTest http/tests/inspector/filesystem/* should clean up FileSystem after test.
Summary: Web Inspector: LayoutTest http/tests/inspector/filesystem/* should clean up F...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Taiju Tsuiki
URL:
Keywords:
Depends on:
Blocks: 68203 89190
  Show dependency treegraph
 
Reported: 2012-06-13 23:33 PDT by Taiju Tsuiki
Modified: 2012-06-15 02:33 PDT (History)
11 users (show)

See Also:


Attachments
Patch (5.12 KB, patch)
2012-06-13 23:35 PDT, Taiju Tsuiki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Taiju Tsuiki 2012-06-13 23:33:10 PDT
http/tests/inspector/filesystem/read-directory.html leaves some file on FileSystem after test.
This causes unexpected error on other FileSystem tests on same DRT instance.
Comment 1 Taiju Tsuiki 2012-06-13 23:35:30 PDT
Created attachment 147498 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-06-14 06:40:29 PDT
Comment on attachment 147498 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147498&action=review

> LayoutTests/http/tests/inspector/filesystem/filesystem-test.js:59
> +    testRunner.evaluateInWebInspector(999, "InspectorTest.dispatchCallback(unescape(\"" + escape(args) + "\"))");

Why did 0 change to 999?
Comment 3 Taiju Tsuiki 2012-06-14 20:29:12 PDT
Comment on attachment 147498 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147498&action=review

>> LayoutTests/http/tests/inspector/filesystem/filesystem-test.js:59
>> +    testRunner.evaluateInWebInspector(999, "InspectorTest.dispatchCallback(unescape(\"" + escape(args) + "\"))");
> 
> Why did 0 change to 999?

This is callId of the evaluation and callId == 0 is used as runTestCallId in inspector-test.js.
I'd like to avoid using same ID here.
Comment 4 WebKit Review Bot 2012-06-15 02:33:28 PDT
Comment on attachment 147498 [details]
Patch

Clearing flags on attachment: 147498

Committed r120430: <http://trac.webkit.org/changeset/120430>
Comment 5 WebKit Review Bot 2012-06-15 02:33:33 PDT
All reviewed patches have been landed.  Closing bug.