RESOLVED FIXED 89062
[Chromium][Forms] We should remove ENABLE_INPUT_TYPE_TIME=0 and so on to allows us to override them by ~/.gyp/include.gypi 
https://bugs.webkit.org/show_bug.cgi?id=89062
Summary [Chromium][Forms] We should remove ENABLE_INPUT_TYPE_TIME=0 and so on to allo...
yosin
Reported 2012-06-13 23:03:35 PDT
There are ENABLE_INPUT_TYPE_MONTH=0, TIME=0, and so on, in WebKit/chromium/features.gyp. It prevents us to use overriding them in ~/.gyp/include.gypi.
Attachments
Patch 1 (1.70 KB, patch)
2012-06-13 23:19 PDT, yosin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
yosin
Comment 1 2012-06-13 23:19:29 PDT
Created attachment 147495 [details] Patch 1
yosin
Comment 2 2012-06-13 23:21:03 PDT
Comment on attachment 147495 [details] Patch 1 Could you review this patch? Thanks in advance. * Local build on CR-Linux with ~/.gyp/include.gypi which contains ENABLE_INPUT_TYPE_TIME=1, and so on. * Confirm local build Chrome support these input types.
Kent Tamura
Comment 3 2012-06-14 01:43:16 PDT
Comment on attachment 147495 [details] Patch 1 ok
WebKit Review Bot
Comment 4 2012-06-14 03:57:55 PDT
Comment on attachment 147495 [details] Patch 1 Clearing flags on attachment: 147495 Committed r120312: <http://trac.webkit.org/changeset/120312>
WebKit Review Bot
Comment 5 2012-06-14 03:57:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.