Bug 89057 – REGRESSION (r120252): run-webkit-tests on Mac fails

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Tim Horton]

Traceback (most recent call last):
  File "/Volumes/Data/Shared/src/WebKit/OpenSource/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 454, in <module>
    sys.exit(main())
  File "/Volumes/Data/Shared/src/WebKit/OpenSource/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 449, in main
    return run(port, options, args)
  File "/Volumes/Data/Shared/src/WebKit/OpenSource/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 118, in run
    manager.parse_expectations()
  File "/Volumes/Data/Shared/src/WebKit/OpenSource/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 367, in parse_expectations
    self._expectations = test_expectations.TestExpectations(self._port, self._test_files)
  File "/Volumes/Data/Shared/src/WebKit/OpenSource/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py", line 741, in __init__
    self._add_expectations(self._expectations)
  File "/Volumes/Data/Shared/src/WebKit/OpenSource/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py", line 882, in _add_expectations
    if self._is_lint_mode or self._test_config in expectation_line.matching_configurations:
  File "/Volumes/Data/Shared/src/WebKit/OpenSource/Tools/Scripts/webkitpy/layout_tests/models/test_configuration.py", line 57, in __hash__
    return hash(self.version + self.architecture + self.build_type)
TypeError: cannot concatenate 'str' and 'NoneType' objects


I have a fix.

[Tim Horton]

Created attachment 147475 [details]
patch

[Tim Horton]

Landed in http://trac.webkit.org/changeset/120272

[Dirk Pranke]

Comment on attachment 147475 [details]
patch

darn ... I keep meaning to fix this stupid interface; it's bug 87413. This was a regression I introduced in http://trac.webkit.org/changeset/120252 . I noticed this earlier today but  forgot about it when I went on to test something using my chromium build instead :( Thanks for fixing!

[Dirk Pranke]

Comment on attachment 147475 [details]
patch

I thought we had unit tests that at least instantiated all of ports, so I'm surprised we didn't catch this in the unit tests. I'll have to add something for that.