RESOLVED FIXED89049
[chromium] For hit testing in CCLayerTreeHostCommon, need to check that the transform is invertible before inverting it 
https://bugs.webkit.org/show_bug.cgi?id=89049
Summary [chromium] For hit testing in CCLayerTreeHostCommon, need to check that the t...
Shawn Singh
Reported 2012-06-13 17:35:26 PDT
Just a small oversight, but it could be important to add this back. Is it worth adding a unit test? I can... Patch coming in a short while.
Attachments
Patch (6.35 KB, patch)
2012-06-13 18:03 PDT, Shawn Singh 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ec2-cq-02 (735.19 KB, application/zip)
2012-06-14 02:18 PDT, WebKit Review Bot 		no flags
Details
Patch for landing (6.31 KB, patch)
2012-06-14 11:30 PDT, Shawn Singh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Shawn Singh
Comment 1 2012-06-13 18:03:08 PDT
Created attachment 147454 [details] Patch
Adrienne Walker
Comment 2 2012-06-13 18:05:51 PDT
Comment on attachment 147454 [details] Patch R=me. Nice catch.
WebKit Review Bot
Comment 3 2012-06-14 02:18:18 PDT
Comment on attachment 147454 [details] Patch Rejecting attachment 147454 [details] from commit-queue. New failing tests: platform/chromium/compositing/layout-width-change.html platform/chromium/compositing/render-surface-alpha-blending.html platform/chromium/compositing/tiny-layer-rotated.html platform/chromium/compositing/huge-layer-rotated.html fast/loader/loadInProgress.html platform/chromium/compositing/3d-corners.html platform/chromium/compositing/video-frame-size-change.html platform/chromium/compositing/perpendicular-layer-sorting.html fast/loader/unload-form-post-about-blank.html platform/chromium/compositing/child-layer-3d-sorting.html platform/chromium/compositing/accelerated-drawing/svg-filters.html platform/chromium/compositing/lost-compositor-context-permanently.html media/track/track-cue-rendering-snap-to-lines-not-set.html platform/chromium/compositing/filters/background-filter-blur-outsets.html platform/chromium/compositing/lost-compositor-context-with-video.html platform/chromium/compositing/accelerated-drawing/alpha.html http/tests/xmlhttprequest/zero-length-response.html http/tests/security/script-crossorigin-loads-correctly.html platform/chromium/compositing/webgl-loses-compositor-context.html platform/chromium/compositing/backface-visibility-transformed.html platform/chromium/compositing/lost-compositor-context-with-rendersurface.html platform/chromium/compositing/lost-compositor-context.html platform/chromium/compositing/img-layer-grow.html platform/chromium/compositing/filters/background-filter-blur-off-axis.html platform/chromium/compositing/filters/background-filter-blur.html platform/chromium/compositing/lost-compositor-context-twice.html Full output: http://queues.webkit.org/results/12949920
WebKit Review Bot
Comment 4 2012-06-14 02:18:28 PDT
Created attachment 147525 [details] Archive of layout-test-results from ec2-cq-02 The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: ec2-cq-02 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Shawn Singh
Comment 5 2012-06-14 10:52:31 PDT
I'm pretty sure this was a false alarm, I'll rebase and try again soon.
Shawn Singh
Comment 6 2012-06-14 11:30:06 PDT
Created attachment 147622 [details] Patch for landing
WebKit Review Bot
Comment 7 2012-06-14 14:45:37 PDT
Comment on attachment 147622 [details] Patch for landing Clearing flags on attachment: 147622 Committed r120362: <http://trac.webkit.org/changeset/120362>
WebKit Review Bot
Comment 8 2012-06-14 14:45:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.