Bug 89048 - Chinese IM receives incorrect/duplicated key events in text fields in webpages in Safari.
Summary: Chinese IM receives incorrect/duplicated key events in text fields in webpage...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar
Depends on: 90368
Blocks:
  Show dependency tree / graph
 
Reported: 2012-06-13 17:21 PDT by Andreas Kling
Modified: 2012-07-25 10:24 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.22 KB, patch)
2012-06-13 17:41 PDT, Andreas Kling 		darin: review+
Details | Formatted Diff | Diff
proposed fix (2.11 KB, patch)
2012-07-24 17:00 PDT, Alexey Proskuryakov 		kling: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-08 (996.56 KB, application/zip)
2012-07-24 18:01 PDT, WebKit Review Bot 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2012-06-13 17:21:09 PDT 
<rdar://problem/11449702>
Comment 1 Andreas Kling 2012-06-13 17:41:46 PDT 
Created attachment 147449 [details]
Patch
Comment 2 Darin Adler 2012-06-13 18:35:30 PDT 
Comment on attachment 147449 [details]
Patch

Is there some good way to regression-test this?
Comment 3 Andreas Kling 2012-06-14 08:52:48 PDT 
(In reply to comment #2)
> (From update of attachment 147449 [details])
> Is there some good way to regression-test this?

I haven't been able to come up with a good way to manually test this, let alone something we could automate. :/
Comment 4 Andreas Kling 2012-06-14 08:53:04 PDT 
Committed r120329: <http://trac.webkit.org/changeset/120329>
Comment 5 WebKit Review Bot 2012-07-02 02:13:13 PDT 
Re-opened since this is blocked by 90368
Comment 6 Alexey Proskuryakov 2012-07-24 17:00:44 PDT 
Created attachment 154179 [details]
proposed fix
Comment 7 WebKit Review Bot 2012-07-24 18:01:35 PDT 
Comment on attachment 154179 [details]
proposed fix

Attachment 154179 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13339058

New failing tests:
fast/forms/range/slider-onchange-event.html
fast/forms/range/slider-mouse-events.html
fast/forms/range/slider-delete-while-dragging-thumb.html
Comment 8 WebKit Review Bot 2012-07-24 18:01:39 PDT 
Created attachment 154202 [details]
Archive of layout-test-results from gce-cr-linux-08

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-08  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 9 Andreas Kling 2012-07-25 10:05:59 PDT 
Comment on attachment 154179 [details]
proposed fix

r=me
Comment 10 Alexey Proskuryakov 2012-07-25 10:24:37 PDT 
Landed in <http://trac.webkit.org/changeset/123630> (failing tests on chromium EWS couldn't possibly be related).