Bug 89044 - Remove the const keyword from MediaPlayerPrivate::enterFullscreen()
Summary: Remove the const keyword from MediaPlayerPrivate::enterFullscreen()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 66687
  Show dependency tree / graph
 
Reported: 2012-06-13 15:40 PDT by Min Qin
Modified: 2012-06-14 02:26 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.48 KB, patch)
2012-06-13 15:44 PDT, Min Qin 		no flags Details | Formatted Diff | Diff
Patch (2.74 KB, patch)
2012-06-13 15:55 PDT, Min Qin 		no flags Details | Formatted Diff | Diff
Patch (3.72 KB, patch)
2012-06-13 16:12 PDT, Min Qin 		no flags Details | Formatted Diff | Diff
Patch (3.71 KB, patch)
2012-06-13 16:15 PDT, Min Qin 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Min Qin 2012-06-13 15:40:19 PDT 
Remove the const keyword from MediaPlayerPrivate::enterFullscreen()
Comment 1 Min Qin 2012-06-13 15:44:11 PDT 
Created attachment 147432 [details]
Patch
Comment 2 Peter Beverloo 2012-06-13 15:49:23 PDT 
You'll want to revert the changes made in r120213 as well, as well as any downstream change.
Comment 3 Min Qin 2012-06-13 15:55:13 PDT 
Created attachment 147434 [details]
Patch
Comment 4 Min Qin 2012-06-13 15:57:18 PDT 
Did not notice that we have changed WebMediaPlayerClientImpl.
Reverted that change as a result of this change.

(In reply to comment #2)
> You'll want to revert the changes made in r120213 as well, as well as any downstream change.
Comment 5 Peter Beverloo 2012-06-13 15:57:29 PDT 
Comment on attachment 147434 [details]
Patch

Please also amend Source/WebKit/chromium/ChangeLog with the change. LGTM after that, thank you! You could carry-over Adam's r+ by changing the "Reviewed by" line in the changelog, I (of anyone else) can put the patch on the commit queue after that.
Comment 6 Min Qin 2012-06-13 16:12:21 PDT 
Created attachment 147441 [details]
Patch
Comment 7 Peter Beverloo 2012-06-13 16:13:48 PDT 
LGTM. Adam, could you take a look and r+/cq+ please?
Comment 8 Min Qin 2012-06-13 16:15:28 PDT 
Created attachment 147442 [details]
Patch
Comment 9 Min Qin 2012-06-13 16:16:43 PDT 
Done, added the chromium ChangeLog and changed the reviewer to Adam

(In reply to comment #5)
> (From update of attachment 147434 [details])
> Please also amend Source/WebKit/chromium/ChangeLog with the change. LGTM after that, thank you! You could carry-over Adam's r+ by changing the "Reviewed by" line in the changelog, I (of anyone else) can put the patch on the commit queue after that.
Comment 10 WebKit Review Bot 2012-06-14 02:26:09 PDT 
Comment on attachment 147442 [details]
Patch

Clearing flags on attachment: 147442

Committed r120298: <http://trac.webkit.org/changeset/120298>
Comment 11 WebKit Review Bot 2012-06-14 02:26:22 PDT 
All reviewed patches have been landed.  Closing bug.