Bug 89025 – [chromium] Upstream LayerRendererChromium::drawHighlightQuads from Android port

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: New Bugs

[Iain Merrick]

[chromium] Upstream LayerRendererChromium::drawHighlightQuads from Android port

[Iain Merrick]

Created attachment 147373 [details]
Patch

[Iain Merrick]

This is the code currently used by the Android port.

[Dana Jansens]

Is the code at all related/similar to link highlight, or could/should it be?

[W. James MacLean]

This looks very related to work already underway at 

https://bugs.webkit.org/show_bug.cgi?id=84487

I don't think we want two different mechanisms, and  if I recall earlier discussions with Nat & James R, there was a desire to not hardwire highlight drawing directly into the compositor.

Is there anything we can do in the existing work to accommodate what you're trying to do?

[James Robinson]

Comment on attachment 147373 [details]
Patch

I don't think it makes sense to build this directly into the compositor - instead, the caller should construct an appropriate layer and set the right bits on it (assuming that this is initiated from the main thread, which appears to be the case).

[Iain Merrick]

This wasn't written by me originally, I'm just unforking code that has been shipped already. I'll take a look at 84487.

[Iain Merrick]

*** This bug has been marked as a duplicate of bug 84487 ***

[Alexandre Elias]

I'll delete this code from the Android branch as there's no plan to ship it again.