Bug 89020 - [BlackBerry] Apply New Style and JS for Select Popup
Summary: [BlackBerry] Apply New Style and JS for Select Popup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 89005
Blocks:
  Show dependency tree / graph
 
Reported: 2012-06-13 10:44 PDT by Crystal Zhang
Modified: 2012-06-13 19:36 PDT (History)
3 users (show)

See Also:

Attachments
patch (10.26 KB, patch)
2012-06-13 11:29 PDT, Crystal Zhang 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Crystal Zhang 2012-06-13 10:44:11 PDT 
Use new styled CSS files for select popup, also remove most JS functions to a separate JS file, only pass the parameters to JS, and use new python script for data generating, as the old one is too simple and problematic.
Comment 1 Crystal Zhang 2012-06-13 11:29:25 PDT 
Created attachment 147371 [details]
patch
Comment 2 Rob Buis 2012-06-13 12:14:29 PDT 
Comment on attachment 147371 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147371&action=review

Looks good.

> Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp:31
> +#include "PopupPicker.h"

The name is slightly generic, I hope we do not have a name clash later....
Comment 3 WebKit Review Bot 2012-06-13 19:36:49 PDT 
Comment on attachment 147371 [details]
patch

Clearing flags on attachment: 147371

Committed r120267: <http://trac.webkit.org/changeset/120267>
Comment 4 WebKit Review Bot 2012-06-13 19:36:53 PDT 
All reviewed patches have been landed.  Closing bug.