Move JSDeprecatedPeerConnectionCustom.cpp from CMakeLists.txt to UseJSC.cmake.
Created attachment 147356 [details] Patch
Thanks for the patch. I agree this file should move to UseJSC.cmake.
Comment on attachment 147356 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147356&action=review > Source/WebCore/UseJSC.cmake:300 > +IF (ENABLE_MEDIA_STREAM) > + LIST (APPEND WebCore_SOURCES > + bindings/js/JSDeprecatedPeerConnectionCustom.cpp > + ) > +ENDIF () I think you can add this file to the list unconditionally, as it is already protected by an #ifdef.
Comment on attachment 147356 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147356&action=review >> Source/WebCore/UseJSC.cmake:300 >> +ENDIF () > > I think you can add this file to the list unconditionally, as it is already protected by an #ifdef. Yes, it can be moved outside of ifdef guards. I just followed same as other modules included the .cpp files.
Created attachment 147548 [details] Patch Fixed review comment #3.
Looks fine to me.
Comment on attachment 147548 [details] Patch Clearing flags on attachment: 147548 Committed r120382: <http://trac.webkit.org/changeset/120382>
All reviewed patches have been landed. Closing bug.