Bug 89015 – [CMAKE] Move JSDeprecatedPeerConnectionCustom.cpp from CMakeLists.txt to UseJSC.cmake

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sudarsana Nagineni (babu)]

Move JSDeprecatedPeerConnectionCustom.cpp from CMakeLists.txt to UseJSC.cmake.

[Sudarsana Nagineni (babu)]

Created attachment 147356 [details]
Patch

[Robin Cao]

Thanks for the patch. I agree this file should move to UseJSC.cmake.

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 147356 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147356&action=review

> Source/WebCore/UseJSC.cmake:300
> +IF (ENABLE_MEDIA_STREAM)
> +    LIST (APPEND WebCore_SOURCES
> +        bindings/js/JSDeprecatedPeerConnectionCustom.cpp
> +    )
> +ENDIF ()

I think you can add this file to the list unconditionally, as it is already protected by an #ifdef.

[Sudarsana Nagineni (babu)]

Comment on attachment 147356 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147356&action=review

>> Source/WebCore/UseJSC.cmake:300
>> +ENDIF ()
> 
> I think you can add this file to the list unconditionally, as it is already protected by an #ifdef.

Yes, it can be moved outside of ifdef guards. I just followed same as other modules included the .cpp files.

[Sudarsana Nagineni (babu)]

Created attachment 147548 [details]
Patch

Fixed review comment #3.

[Raphael Kubo da Costa (:rakuco)]

Looks fine to me.

[WebKit Review Bot]

Comment on attachment 147548 [details]
Patch

Clearing flags on attachment: 147548

Committed r120382: <http://trac.webkit.org/changeset/120382>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.