Bug 89009 - [WinCairo] Update WinCairoRequirements.zip Download Location
Summary: [WinCairo] Update WinCairoRequirements.zip Download Location
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-13 09:21 PDT by Brent Fulgham
Modified: 2012-06-13 12:28 PDT (History)
0 users

See Also:

Attachments
Patch (3.09 KB, patch)
2012-06-13 11:01 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (3.29 KB, patch)
2012-06-13 11:59 PDT, Brent Fulgham 		mrobinson: review+
mrobinson: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2012-06-13 09:21:29 PDT 
Due to the imminent shutdown of the "mobileMe" web service, I had to move the WinCairoRequirements.zip bundle from my public iDisk to my public DropBox account.

This update changes the URL of the package.
Comment 1 Brent Fulgham 2012-06-13 11:01:08 PDT 
Created attachment 147363 [details]
Patch
Comment 2 Brent Fulgham 2012-06-13 11:59:21 PDT 
Created attachment 147381 [details]
Patch
Comment 3 Martin Robinson 2012-06-13 12:15:19 PDT 
Comment on attachment 147381 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147381&action=review

> Tools/Scripts/update-webkit-dependency:80
> +    #Note: Neither GitHub nor DropBox emit the Last-Modified HTTP header, so use the "Date" field instead.

Nit: missing a space here after the #

Is this comment accurate? It seems that what's happening here is that it's fetching a file catch "$file.headers" instead of checking the date field.
Comment 4 Martin Robinson 2012-06-13 12:18:07 PDT 
Comment on attachment 147381 [details]
Patch

Looks good, but remove the inaccurate comment. :)
Comment 5 Brent Fulgham 2012-06-13 12:28:44 PDT 
Committed r120235: <http://trac.webkit.org/changeset/120235>