Bug 89004 - [chromium] Assert if iterating an invalid RenderSurfaceLayerList, where a layer in the list has no RenderSurface
Summary: [chromium] Assert if iterating an invalid RenderSurfaceLayerList, where a lay...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dana Jansens
URL:
Keywords:
Depends on: 88886
Blocks:
  Show dependency tree / graph
 
Reported: 2012-06-13 08:45 PDT by Dana Jansens
Modified: 2012-06-13 19:27 PDT (History)
8 users (show)

See Also:

Attachments
Patch (7.52 KB, patch)
2012-06-13 08:50 PDT, Dana Jansens 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dana Jansens 2012-06-13 08:45:49 PDT 
[chromium] Assert if iterating an invalid RenderSurfaceLayerList, where a layer in the list has no RenderSurface
Comment 1 Dana Jansens 2012-06-13 08:50:46 PDT 
Created attachment 147329 [details]
Patch
Comment 2 Dana Jansens 2012-06-13 08:52:55 PDT 
I had removed the unit test for an invalid RSLL (layers with no surface in the list), but maybe we want to keep the test in release mode to demonstrate it doesn't crash on invalid input? (From discussion on bug #88886)
Comment 3 Adrienne Walker 2012-06-13 17:42:02 PDT 
Comment on attachment 147329 [details]
Patch

R=me.  Seems like a reasonable way to handle that error.
Comment 4 WebKit Review Bot 2012-06-13 19:27:37 PDT 
Comment on attachment 147329 [details]
Patch

Clearing flags on attachment: 147329

Committed r120266: <http://trac.webkit.org/changeset/120266>
Comment 5 WebKit Review Bot 2012-06-13 19:27:41 PDT 
All reviewed patches have been landed.  Closing bug.