Bug 89003 - Web Inspector: Breakpoint's _uiLocationRemoved() method is never called.
Summary: Web Inspector: Breakpoint's _uiLocationRemoved() method is never called.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-13 08:26 PDT by Vsevolod Vlasov
Modified: 2012-06-13 10:33 PDT (History)
10 users (show)

See Also:

Attachments
Patch (4.65 KB, patch)
2012-06-13 08:28 PDT, Vsevolod Vlasov 		pfeldman: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2012-06-13 08:26:09 PDT 
When _locationUpdated is called on breakpoint, _uiLocationRemoved should be called for primaryUILocation and oldUILocation.
It doesn't now because map is used incorrectly.
Comment 1 Vsevolod Vlasov 2012-06-13 08:28:22 PDT 
Created attachment 147322 [details]
Patch
Comment 2 Pavel Feldman 2012-06-13 09:26:37 PDT 
Comment on attachment 147322 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147322&action=review

> Source/WebCore/inspector/front-end/BreakpointManager.js:265
> +    /** @type {Object.<string, WebInspector.UILocation>} */ 

swap the two
Comment 3 Vsevolod Vlasov 2012-06-13 10:33:10 PDT 
Committed r120223: <http://trac.webkit.org/changeset/120223>