RESOLVED FIXED 88993
[Qt] Remove dependency to QtScript for the Qt 5 build 
https://bugs.webkit.org/show_bug.cgi?id=88993
Summary [Qt] Remove dependency to QtScript for the Qt 5 build
Simon Hausmann
Reported 2012-06-13 05:38:21 PDT
[Qt] Remove dependency to QtScript for the Qt 5 build
Attachments
Patch (18.16 KB, patch)
2012-06-13 06:01 PDT, Simon Hausmann 		kenneth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Hausmann
Comment 1 2012-06-13 06:01:56 PDT
Created attachment 147305 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2012-06-13 06:03:55 PDT
Comment on attachment 147305 [details] Patch rs=me
WebKit Review Bot
Comment 3 2012-06-13 06:05:06 PDT
Attachment 147305 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebKit/qt/Api/qwebframe.h:143: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit/qt/Api/qwebframe.h:143: The parameter name "ownership" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit/qt/Api/qwebframe.h:145: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit/qt/Api/qwebframe.h:145: The parameter name "ownership" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 4 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Lars Knoll
Comment 4 2012-06-13 06:15:45 PDT
Comment on attachment 147305 [details] Patch Looks good.
Simon Hausmann
Comment 5 2012-06-13 08:14:15 PDT
Committed r120196: <http://trac.webkit.org/changeset/120196>
Note You need to log in before you can comment on or make changes to this bug.