Bug 88993 - [Qt] Remove dependency to QtScript for the Qt 5 build
Summary: [Qt] Remove dependency to QtScript for the Qt 5 build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Hausmann
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-13 05:38 PDT by Simon Hausmann
Modified: 2012-06-13 08:14 PDT (History)
1 user (show)

See Also:

Attachments
Patch (18.16 KB, patch)
2012-06-13 06:01 PDT, Simon Hausmann 		kenneth: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Hausmann 2012-06-13 05:38:21 PDT 
[Qt] Remove dependency to QtScript for the Qt 5 build
Comment 1 Simon Hausmann 2012-06-13 06:01:56 PDT 
Created attachment 147305 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-06-13 06:03:55 PDT 
Comment on attachment 147305 [details]
Patch

rs=me
Comment 3 WebKit Review Bot 2012-06-13 06:05:06 PDT 
Attachment 147305 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebKit/qt/Api/qwebframe.h:143:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/Api/qwebframe.h:143:  The parameter name "ownership" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/Api/qwebframe.h:145:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/qt/Api/qwebframe.h:145:  The parameter name "ownership" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 4 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Lars Knoll 2012-06-13 06:15:45 PDT 
Comment on attachment 147305 [details]
Patch

Looks good.
Comment 5 Simon Hausmann 2012-06-13 08:14:15 PDT 
Committed r120196: <http://trac.webkit.org/changeset/120196>