RESOLVED FIXED 88988
Web Inspector: DebuggerModel should support setting breakpoints without script by sourceURL only. 
https://bugs.webkit.org/show_bug.cgi?id=88988
Summary Web Inspector: DebuggerModel should support setting breakpoints without scrip...
Vsevolod Vlasov
Reported 2012-06-13 04:32:04 PDT
This change allows setting all saved breakpoints in debugger model by url before the site with corresponding scripts was loaded (allows breaking in onload handler on first load). This change also simplifies implementation of snippets debugging.
Attachments
Patch (6.46 KB, patch)
2012-06-13 04:57 PDT, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Patch (3.71 KB, patch)
2012-06-14 09:22 PDT, Vsevolod Vlasov 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2012-06-13 04:57:16 PDT
Created attachment 147294 [details] Patch
Pavel Feldman
Comment 2 2012-06-13 05:49:03 PDT
Comment on attachment 147294 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147294&action=review > Source/WebCore/inspector/front-end/DebuggerModel.js:59 > +WebInspector.DebuggerModel.Location = function(scriptId, sourceURL, lineNumber, columnNumber) Shouldn't sourceURL be optional for debugger location? For example it does not exist for eval scripts. > Source/WebCore/inspector/front-end/DebuggerModel.js:136 > setBreakpointByScriptLocation: function(rawLocation, condition, callback) Should we be more specific here and introduce another method instead?
Vsevolod Vlasov
Comment 3 2012-06-14 09:22:13 PDT
Created attachment 147598 [details] Patch
Vsevolod Vlasov
Comment 4 2012-06-14 09:57:30 PDT
Committed r120335: <http://trac.webkit.org/changeset/120335>
Note You need to log in before you can comment on or make changes to this bug.