Bug 88988 - Web Inspector: DebuggerModel should support setting breakpoints without script by sourceURL only.
Summary: Web Inspector: DebuggerModel should support setting breakpoints without scrip...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
Depends on:
Reported: 2012-06-13 04:32 PDT by Vsevolod Vlasov
Modified: 2012-06-14 09:57 PDT (History)
10 users (show)

See Also:

Patch (6.46 KB, patch)
2012-06-13 04:57 PDT, Vsevolod Vlasov
no flags Details | Formatted Diff | Diff
Patch (3.71 KB, patch)
2012-06-14 09:22 PDT, Vsevolod Vlasov
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2012-06-13 04:32:04 PDT
This change allows setting all saved breakpoints in debugger model by url before the site with corresponding scripts was loaded (allows breaking in onload handler on first load).
This change also simplifies implementation of snippets debugging.
Comment 1 Vsevolod Vlasov 2012-06-13 04:57:16 PDT
Created attachment 147294 [details]
Comment 2 Pavel Feldman 2012-06-13 05:49:03 PDT
Comment on attachment 147294 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=147294&action=review

> Source/WebCore/inspector/front-end/DebuggerModel.js:59
> +WebInspector.DebuggerModel.Location = function(scriptId, sourceURL, lineNumber, columnNumber)

Shouldn't sourceURL be optional for debugger location? For example it does not exist for eval scripts.

> Source/WebCore/inspector/front-end/DebuggerModel.js:136
>      setBreakpointByScriptLocation: function(rawLocation, condition, callback)

Should we be more specific here and introduce another method instead?
Comment 3 Vsevolod Vlasov 2012-06-14 09:22:13 PDT
Created attachment 147598 [details]
Comment 4 Vsevolod Vlasov 2012-06-14 09:57:30 PDT
Committed r120335: <http://trac.webkit.org/changeset/120335>