Bug 88987 - [Chromium] Fix Clang build with USE(NATIVE_FULLSCREEN_VIDEO)=1
Summary: [Chromium] Fix Clang build with USE(NATIVE_FULLSCREEN_VIDEO)=1
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Peter Beverloo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-13 04:28 PDT by Peter Beverloo
Modified: 2012-06-13 08:29 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.33 KB, patch)
2012-06-13 04:29 PDT, Peter Beverloo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Beverloo 2012-06-13 04:28:10 PDT
[Chromium] Fix Clang build with USE(NATIVE_FULLSCREEN_VIDEO)=1
Comment 1 Peter Beverloo 2012-06-13 04:29:52 PDT
Created attachment 147288 [details]
Patch
Comment 2 Hans Wennborg 2012-06-13 05:26:56 PDT
Looks good to me.

Note that this does not just "fix the Clang build". It also presumably makes the code work, because without the const qualifier, the function doesn't override anything, and won't get called.
Comment 3 Simon Hausmann 2012-06-13 08:01:49 PDT
Comment on attachment 147288 [details]
Patch

r=me
Comment 4 WebKit Review Bot 2012-06-13 08:29:53 PDT
Comment on attachment 147288 [details]
Patch

Clearing flags on attachment: 147288

Committed r120213: <http://trac.webkit.org/changeset/120213>
Comment 5 WebKit Review Bot 2012-06-13 08:29:59 PDT
All reviewed patches have been landed.  Closing bug.