Bug 88979 - [Forms] Make RenderTextSingleLine usable from any element
Summary: [Forms] Make RenderTextSingleLine usable from any element
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: yosin
URL:
Keywords:
Depends on: 88980
Blocks:
  Show dependency tree / graph
 
Reported: 2012-06-13 03:06 PDT by yosin
Modified: 2012-06-26 22:00 PDT (History)
6 users (show)

See Also:

Attachments
Patch 1 - WIP (37.28 KB, text/plain)
2012-06-18 03:11 PDT, yosin 		webkit-ews: commit-queue-
Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description yosin 2012-06-13 03:06:21 PDT 
This is part of implementing single line text edit control in shadow DOM.
Comment 1 yosin 2012-06-18 03:11:21 PDT 
Created attachment 148079 [details]
Patch 1 - WIP
Comment 2 yosin 2012-06-18 03:14:05 PDT 
Comment on attachment 148079 [details]
Patch 1 - WIP

Could you review this patch as architecture review?

Possible options are:
1. Proceed as is
2. Making SingleLineTextEditField in this patch
3. Or, another

Thanks in advance.
Comment 3 Early Warning System Bot 2012-06-18 03:33:31 PDT 
Comment on attachment 148079 [details]
Patch 1 - WIP

Attachment 148079 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12821025
Comment 4 Build Bot 2012-06-18 03:34:16 PDT 
Comment on attachment 148079 [details]
Patch 1 - WIP

Attachment 148079 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12982039
Comment 5 Early Warning System Bot 2012-06-18 03:35:00 PDT 
Comment on attachment 148079 [details]
Patch 1 - WIP

Attachment 148079 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12985019
Comment 6 yosin 2012-06-18 05:11:24 PDT 
Comment on attachment 148079 [details]
Patch 1 - WIP

It seems making TextControlSingleLine shadow element derived from HTMLTextFormControlElement is better than set RenderTextControl free from HTMLTextFormControlElement.
Comment 7 yosin 2012-06-26 22:00:21 PDT 
Postpone until we improve test coverage.