Bug 88976 - REGRESSION(r120172): The patch causes compilation failures on Gtk, Qt and Apple Win bots (Requested by zdobersek on #webkit).
Summary: REGRESSION(r120172): The patch causes compilation failures on Gtk, Qt and App...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: WebKit Review Bot
URL:
Keywords:
Depends on:
Blocks: 88692
  Show dependency treegraph
 
Reported: 2012-06-13 02:21 PDT by WebKit Review Bot
Modified: 2012-06-13 11:33 PDT (History)
4 users (show)

See Also:


Attachments
ROLLOUT of r120172 (151.01 KB, patch)
2012-06-13 02:22 PDT, WebKit Review Bot
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2012-06-13 02:21:34 PDT
http://trac.webkit.org/changeset/120172 broke the build:
The patch causes compilation failures on Gtk, Qt and Apple Win bots (Requested by zdobersek on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2012-06-13 02:22:22 PDT
Created attachment 147265 [details]
ROLLOUT of r120172

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 3 Zan Dobersek 2012-06-13 02:33:24 PDT
The GTK build error seemed to be just a temporary hick-up. CC-ing Ossy to get the Qt folk's attention about the errors.
Comment 4 Zan Dobersek 2012-06-13 02:38:48 PDT
Comment on attachment 147265 [details]
ROLLOUT of r120172

Clearing flags on attachment: 147265

Committed r120175: <http://trac.webkit.org/changeset/120175>
Comment 5 Zan Dobersek 2012-06-13 02:38:55 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Filip Pizlo 2012-06-13 11:33:47 PDT
The GTK+ failure seems to just be a problem on the GTK bots - the compiler was running out of memory.  Nothing I can do about that.  I will ignore that when rolling this back in.