Bug 88976 – REGRESSION(r120172): The patch causes compilation failures on Gtk, Qt and Apple Win bots (Requested by zdobersek on #webkit).

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Review Bot]

http://trac.webkit.org/changeset/120172 broke the build:
The patch causes compilation failures on Gtk, Qt and Apple Win bots (Requested by zdobersek on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 147265 [details]
ROLLOUT of r120172

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[Zan Dobersek]

Errors:
http://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/31631/steps/compile-webkit/logs/stdio
http://build.webkit.org/builders/Qt%20Linux%20ARMv7%20Release/builds/47182/steps/compile-webkit/logs/stdio
http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release/builds/25151/steps/compile-webkit/logs/stdio

[Zan Dobersek]

The GTK build error seemed to be just a temporary hick-up. CC-ing Ossy to get the Qt folk's attention about the errors.

[Zan Dobersek]

Comment on attachment 147265 [details]
ROLLOUT of r120172

Clearing flags on attachment: 147265

Committed r120175: <http://trac.webkit.org/changeset/120175>

[Zan Dobersek]

All reviewed patches have been landed.  Closing bug.

[Filip Pizlo]

The GTK+ failure seems to just be a problem on the GTK bots - the compiler was running out of memory.  Nothing I can do about that.  I will ignore that when rolling this back in.