Bug 88975 - Update pywebsocket to 0.7.6 from 0.7.4
Summary: Update pywebsocket to 0.7.6 from 0.7.4
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Takashi Toyoshima
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-13 02:20 PDT by Takashi Toyoshima
Modified: 2012-06-14 05:40 PDT (History)
7 users (show)

See Also:


Attachments
Patch (37.71 KB, patch)
2012-06-13 23:23 PDT, Takashi Toyoshima
no flags Details | Formatted Diff | Diff
Patch (37.71 KB, patch)
2012-06-13 23:48 PDT, Takashi Toyoshima
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Takashi Toyoshima 2012-06-13 02:20:44 PDT
New feature
 - Allow handlers to send a close frame with empty body in response of a client initiated closing handshake
 - Implement perframe compression extension
 - Support client certificate authentication

Misc
 - Implement faster masking
 - Improve console.html for test
 - Implement strict check on sending close code and control frame body size
 - Add new custom log level 'FINE' and 'FINER' for debug
Comment 1 Takashi Toyoshima 2012-06-13 23:23:41 PDT
Created attachment 147496 [details]
Patch
Comment 2 Kenichi Ishibashi 2012-06-13 23:45:00 PDT
Comment on attachment 147496 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147496&action=review

LGTM

> Tools/ChangeLog:12
> +        Reviewed by NOBODY (OOPS!).

nit: "Reviewed by" line usually appears before the description.
Comment 3 Takashi Toyoshima 2012-06-13 23:48:03 PDT
Created attachment 147499 [details]
Patch
Comment 4 Takashi Toyoshima 2012-06-13 23:49:03 PDT
> nit: "Reviewed by" line usually appears before the description.

Oops.
Thank you, Kenichi.
Comment 5 Kent Tamura 2012-06-14 00:02:14 PDT
Comment on attachment 147499 [details]
Patch

looks ok
Comment 6 WebKit Review Bot 2012-06-14 05:40:48 PDT
Comment on attachment 147499 [details]
Patch

Clearing flags on attachment: 147499

Committed r120315: <http://trac.webkit.org/changeset/120315>
Comment 7 WebKit Review Bot 2012-06-14 05:40:55 PDT
All reviewed patches have been landed.  Closing bug.