Bug 88931 - some headers are included twice in WebCore
Summary: some headers are included twice in WebCore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-12 15:34 PDT by arno.
Modified: 2012-06-13 22:11 PDT (History)
8 users (show)

See Also:

Attachments
patch proposal (6.59 KB, patch)
2012-06-12 15:37 PDT, arno. 		no flags Details | Formatted Diff | Diff
updated patch (6.08 KB, patch)
2012-06-13 13:05 PDT, arno. 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description arno. 2012-06-12 15:34:58 PDT 
In some WebCore, there are a few file with the same header included twice.
Comment 1 arno. 2012-06-12 15:37:34 PDT 
Created attachment 147179 [details]
patch proposal
Comment 2 Adam Barth 2012-06-12 16:01:26 PDT 
Comment on attachment 147179 [details]
patch proposal

View in context: https://bugs.webkit.org/attachment.cgi?id=147179&action=review

> Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:-38
> -#include "JSTestObj.h"

This is a generated file.  Please don't edit it.  (Note: It should say that at the top.)
Comment 3 Rob Buis 2012-06-13 12:45:24 PDT 
Comment on attachment 147179 [details]
patch proposal

View in context: https://bugs.webkit.org/attachment.cgi?id=147179&action=review

Looks good, but you should try to remove the one so not to make the sorting worse. Also r- based on Adam's comment.

> Source/WebCore/rendering/InlineFlowBox.cpp:-39
> -#include "RootInlineBox.h"

I think you should remove the first occurrence of it, otherwise you violate (or keep violating) the alphabetic sorting rule.
Comment 4 arno. 2012-06-13 13:05:44 PDT 
Created attachment 147396 [details]
updated patch
Comment 5 WebKit Review Bot 2012-06-13 22:11:00 PDT 
Comment on attachment 147396 [details]
updated patch

Clearing flags on attachment: 147396

Committed r120279: <http://trac.webkit.org/changeset/120279>
Comment 6 WebKit Review Bot 2012-06-13 22:11:05 PDT 
All reviewed patches have been landed.  Closing bug.