Bug 88914 - builders.py should autogenerate the list of builders from the buildbot json
Summary: builders.py should autogenerate the list of builders from the buildbot json
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-12 13:58 PDT by Ojan Vafai
Modified: 2012-06-12 14:03 PDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2012-06-12 13:58:55 PDT
We shouldn't need to manually keep this list up to date. We should grab the list of builders from the buildbot json and filter out the non-testers. The flakiness dashboard does this and it requires almost no manual maintenance. See requestBuilderList in http://trac.webkit.org/browser/trunk/Tools/TestResultServer/static-dashboards/builders.js#L134.

The only tricky bit here is that builders.py has extra metadata that we'd have to infer from the buildername, specifically port_name and specifiers. Actually, now that I think about this more, is this the only place we map builder name to port name? Maybe we do need this list after all. :( Dirk or Adam, WDYT?

While we're at it we probably want to improve the naming so that it's clear that this list only contains testers.
Comment 1 Dirk Pranke 2012-06-12 14:01:09 PDT
(In reply to comment #0)
> The only tricky bit here is that builders.py has extra metadata that we'd have to infer from the buildername, specifically port_name and specifiers. Actually, now that I think about this more, is this the only place we map builder name to port name? Maybe we do need this list after all. :( Dirk or Adam, WDYT?
> 

Yeah, I dont know how you'd grab that data otherwise. I suppose you could then fetch individual results.json from the bots and extract the port name from that, but I'm not convinced it's worth it.

This list doesn't change very often; I think trying to automatically generate it sounds like it's more trouble than it is worth.
Comment 2 Ojan Vafai 2012-06-12 14:03:52 PDT
Yeah, I just didn't think through this very clearly I think. Feel free to reopen if you think of a way to simplify maintaining this list.